[Turbofan] Clean up register allocator and verifier code.

[Turbofan] Clean up register allocator and verifier code.

- Improves RegisterName display in register allocator.
- Removes GetFixedRegisters method in preparation for having multiple fp
reg types.
- Clean up some verifier code.

LOG=N
BUG=v8:4124
Committed: https://crrev.com/d99e1ab60557e86b62ccc6c91514e817c0df370d
Cr-Commit-Position: refs/heads/master@{#37076}

[bbudge, 2016-06-18 00:16:26]

bbudge@chromium.org changed reviewers:
+ mtrofin@chromium.org

[Mircea Trofin, 2016-06-18 00:39:32]

LGTM, one nit.

https://codereview.chromium.org/2081443002/diff/1/src/compiler/register-alloc...
File src/compiler/register-allocator-verifier.h (right):

https://codereview.chromium.org/2081443002/diff/1/src/compiler/register-alloc...
src/compiler/register-allocator-verifier.h:108: const PendingAssessment*
original_pending_assessment() const {
Can you move this line back to where it was, since it's not a change?

[bbudge, 2016-06-18 22:15:51]

https://codereview.chromium.org/2081443002/diff/1/src/compiler/register-alloc...
File src/compiler/register-allocator-verifier.h (right):

https://codereview.chromium.org/2081443002/diff/1/src/compiler/register-alloc...
src/compiler/register-allocator-verifier.h:108: const PendingAssessment*
original_pending_assessment() const {
On 2016/06/18 00:39:32, Mircea Trofin wrote:
> Can you move this line back to where it was, since it's not a change?

I moved it so it would be near the other getter, and would match the ordering
for PendingAssessment, where the cast function precedes the getters. But if you
want it back the way it was, I'll undo it.

[Mircea Trofin, 2016-06-18 23:08:59]

On 2016/06/18 22:15:51, bbudge wrote:
>
https://codereview.chromium.org/2081443002/diff/1/src/compiler/register-alloc...
> File src/compiler/register-allocator-verifier.h (right):
> 
>
https://codereview.chromium.org/2081443002/diff/1/src/compiler/register-alloc...
> src/compiler/register-allocator-verifier.h:108: const PendingAssessment*
> original_pending_assessment() const {
> On 2016/06/18 00:39:32, Mircea Trofin wrote:
> > Can you move this line back to where it was, since it's not a change?
> 
> I moved it so it would be near the other getter, and would match the ordering
> for PendingAssessment, where the cast function precedes the getters. But if
you
> want it back the way it was, I'll undo it.

That's fine - makes sense. Thanks!

[bbudge, 2016-06-18 23:15:07]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2016-06-18 23:15:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081443002/1

[commit-bot: I haz the power, 2016-06-18 23:17:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-18 23:20:03]

Description was changed from

==========
[Turbofan] Clean up register allocator and verifier code.

- Improves RegisterName display in register allocator.
- Removes GetFixedRegisters method in preparation for having multiple fp
reg types.
- Clean up some verifier code.

LOG=N
BUG=v8:4124
==========

to

==========
[Turbofan] Clean up register allocator and verifier code.

- Improves RegisterName display in register allocator.
- Removes GetFixedRegisters method in preparation for having multiple fp
reg types.
- Clean up some verifier code.

LOG=N
BUG=v8:4124

Committed: https://crrev.com/d99e1ab60557e86b62ccc6c91514e817c0df370d
Cr-Commit-Position: refs/heads/master@{#37076}
==========

[commit-bot: I haz the power, 2016-06-18 23:20:04]

Patchset 1 (id:??) landed as
https://crrev.com/d99e1ab60557e86b62ccc6c91514e817c0df370d
Cr-Commit-Position: refs/heads/master@{#37076}

[Michael Achenbach, 2016-06-19 07:35:39]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2078243002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert. Looks like this lets
a few ignition+turbofan tests time out under tsan:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10171.

[bbudge, 2016-06-21 22:03:03]

Description was changed from

==========
[Turbofan] Clean up register allocator and verifier code.

- Improves RegisterName display in register allocator.
- Removes GetFixedRegisters method in preparation for having multiple fp
reg types.
- Clean up some verifier code.

LOG=N
BUG=v8:4124

Committed: https://crrev.com/d99e1ab60557e86b62ccc6c91514e817c0df370d
Cr-Commit-Position: refs/heads/master@{#37076}
==========

to

==========
[Turbofan] Clean up register allocator and verifier code.

- Improves RegisterName display in register allocator.
- Removes GetFixedRegisters method in preparation for having multiple fp
reg types.
- Clean up some verifier code.

LOG=N
BUG=v8:4124

Committed: https://crrev.com/d99e1ab60557e86b62ccc6c91514e817c0df370d
Cr-Commit-Position: refs/heads/master@{#37076}
==========