Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2081443002: [Turbofan] Clean up register allocator and verifier code. (Closed)

Created:
4 years, 6 months ago by bbudge
Modified:
4 years, 5 months ago
Reviewers:
Mircea Trofin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Clean up register allocator and verifier code. - Improves RegisterName display in register allocator. - Removes GetFixedRegisters method in preparation for having multiple fp reg types. - Clean up some verifier code. LOG=N BUG=v8:4124 Committed: https://crrev.com/d99e1ab60557e86b62ccc6c91514e817c0df370d Cr-Commit-Position: refs/heads/master@{#37076}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -41 lines) Patch
M src/compiler/register-allocator.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/register-allocator.cc View 8 chunks +29 lines, -26 lines 0 comments Download
M src/compiler/register-allocator-verifier.h View 4 chunks +7 lines, -13 lines 2 comments Download

Messages

Total messages: 12 (4 generated)
bbudge
4 years, 6 months ago (2016-06-18 00:16:27 UTC) #2
Mircea Trofin
LGTM, one nit. https://codereview.chromium.org/2081443002/diff/1/src/compiler/register-allocator-verifier.h File src/compiler/register-allocator-verifier.h (right): https://codereview.chromium.org/2081443002/diff/1/src/compiler/register-allocator-verifier.h#newcode108 src/compiler/register-allocator-verifier.h:108: const PendingAssessment* original_pending_assessment() const { Can ...
4 years, 6 months ago (2016-06-18 00:39:32 UTC) #3
bbudge
https://codereview.chromium.org/2081443002/diff/1/src/compiler/register-allocator-verifier.h File src/compiler/register-allocator-verifier.h (right): https://codereview.chromium.org/2081443002/diff/1/src/compiler/register-allocator-verifier.h#newcode108 src/compiler/register-allocator-verifier.h:108: const PendingAssessment* original_pending_assessment() const { On 2016/06/18 00:39:32, Mircea ...
4 years, 6 months ago (2016-06-18 22:15:51 UTC) #4
Mircea Trofin
On 2016/06/18 22:15:51, bbudge wrote: > https://codereview.chromium.org/2081443002/diff/1/src/compiler/register-allocator-verifier.h > File src/compiler/register-allocator-verifier.h (right): > > https://codereview.chromium.org/2081443002/diff/1/src/compiler/register-allocator-verifier.h#newcode108 > ...
4 years, 6 months ago (2016-06-18 23:08:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081443002/1
4 years, 6 months ago (2016-06-18 23:15:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-18 23:17:05 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d99e1ab60557e86b62ccc6c91514e817c0df370d Cr-Commit-Position: refs/heads/master@{#37076}
4 years, 6 months ago (2016-06-18 23:20:04 UTC) #10
Michael Achenbach
4 years, 6 months ago (2016-06-19 07:35:39 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2078243002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert. Looks like this lets
a few ignition+turbofan tests time out under tsan:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10171.

Powered by Google App Engine
This is Rietveld 408576698