Use official JSON encoding for stream

Use official JSON encoding for stream

Closes https://github.com/dart-lang/sdk/issues/26721

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/21ce02fb70dba32f64e068ce98ece8e0b9ecdf3c

[cbernaschina, 2016-06-17 22:08:09]

Description was changed from

==========
Use official JSON encoding for stream

Closes https://github.com/dart-lang/sdk/issues/26721
==========

to

==========
Use official JSON encoding for stream

Closes https://github.com/dart-lang/sdk/issues/26721
==========

[cbernaschina, 2016-06-17 22:08:09]

cbernaschina@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com, turnidge@google.com

[cbernaschina, 2016-06-17 22:28:42]

Just a small fix from the previous version

[Cutch, 2016-06-20 13:46:56]

A high level comment- we don't use the stl.

John

[Cutch, 2016-06-20 14:52:32]

On 2016/06/20 14:50:48, cbernaschina wrote:

Ryan should review this CL

[rmacnak, 2016-06-21 16:56:56]

https://codereview.chromium.org/2081433002/diff/40001/runtime/platform/text_b...
File runtime/platform/text_buffer.cc (right):

https://codereview.chromium.org/2081433002/diff/40001/runtime/platform/text_b...
runtime/platform/text_buffer.cc:84: void
TextBuffer::EscapeAndAddCodeUnit(uint32_t codeunit) {
Perhaps this should be split into EscapeAndAddUTF16CodeUnit (with the old
behavior, for encoding Dart strings) and EscapeAndAddCodePoint (with your new
behavior), see below.

https://codereview.chromium.org/2081433002/diff/40001/runtime/vm/json_stream.cc
File runtime/vm/json_stream.cc (right):

https://codereview.chromium.org/2081433002/diff/40001/runtime/vm/json_stream....
runtime/vm/json_stream.cc:828: uint32_t trail = s.CharAt(++i);
A Dart string may have unmatched surrogates, so this might read after the end of
a Dart string or remove a character from the string.

[cbernaschina, 2016-06-21 21:24:43]

https://codereview.chromium.org/2081433002/diff/40001/runtime/platform/text_b...
File runtime/platform/text_buffer.cc (right):

https://codereview.chromium.org/2081433002/diff/40001/runtime/platform/text_b...
runtime/platform/text_buffer.cc:84: void
TextBuffer::EscapeAndAddCodeUnit(uint32_t codeunit) {
On 2016/06/21 16:56:56, rmacnak wrote:
> Perhaps this should be split into EscapeAndAddUTF16CodeUnit (with the old
> behavior, for encoding Dart strings) and EscapeAndAddCodePoint (with your new
> behavior), see below.

Done.

https://codereview.chromium.org/2081433002/diff/40001/runtime/vm/json_stream.cc
File runtime/vm/json_stream.cc (right):

https://codereview.chromium.org/2081433002/diff/40001/runtime/vm/json_stream....
runtime/vm/json_stream.cc:828: uint32_t trail = s.CharAt(++i);
On 2016/06/21 16:56:56, rmacnak wrote:
> A Dart string may have unmatched surrogates, so this might read after the end
of
> a Dart string or remove a character from the string.

Done.

[rmacnak, 2016-06-28 22:39:07]

LGTM

[cbernaschina, 2016-06-28 22:40:16]

Description was changed from

==========
Use official JSON encoding for stream

Closes https://github.com/dart-lang/sdk/issues/26721
==========

to

==========
Use official JSON encoding for stream

Closes https://github.com/dart-lang/sdk/issues/26721

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/21ce02fb70dba32f64e068ce98ece8e0b9ecdf3c
==========

[cbernaschina, 2016-06-28 22:40:17]

Committed patchset #6 (id:100001) manually as
21ce02fb70dba32f64e068ce98ece8e0b9ecdf3c (presubmit successful).