Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1965)

Unified Diff: Source/core/rendering/RenderObject.h

Issue 208143003: Issue trace events to gather repaint information. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderObject.h
diff --git a/Source/core/rendering/RenderObject.h b/Source/core/rendering/RenderObject.h
index a4d483d79055044d9442017b0163d0681bb7a0f1..e93636ff0b09358a3ada8b3b2021601a4f324e98 100644
--- a/Source/core/rendering/RenderObject.h
+++ b/Source/core/rendering/RenderObject.h
@@ -117,6 +117,20 @@ enum MapCoordinatesMode {
};
typedef unsigned MapCoordinatesFlags;
+enum InvalidationReason {
+ InvalidationIncremental,
+ InvalidationSelfLayout,
+ InvalidationBorderFitLines,
+ InvalidationBorderRadius,
+ InvalidationBoundsChangeWithBackground,
+ InvalidationBoundsChange,
+ InvalidationScroll,
+ InvalidationSelection,
+ InvalidationLayer,
+ InvalidationRepaint,
+ InvalidationRepaintRectangle
+};
+
const int caretWidth = 1;
struct AnnotatedRegionValue {
@@ -801,9 +815,10 @@ public:
// if painting is root-relative. This is the container that should be passed to the 'forRepaint'
// methods.
RenderLayerModelObject* containerForRepaint() const;
+
// Actually do the repaint of rect r for this object which has been computed in the coordinate space
// of repaintContainer. If repaintContainer is 0, repaint via the view.
- void repaintUsingContainer(const RenderLayerModelObject* repaintContainer, const IntRect&) const;
+ void repaintUsingContainer(const RenderLayerModelObject* repaintContainer, const IntRect&, InvalidationReason) const;
// Repaint the entire object. Called when, e.g., the color of a border changes, or when a border
// style changes.
@@ -1068,6 +1083,7 @@ private:
#ifndef NDEBUG
void checkBlockPositionedObjectsNeedLayout();
#endif
+ const char* invalidationReasonToString(const InvalidationReason) const;
Julien - ping for review 2014/03/31 20:11:04 Same comment about |const| InvalidationReason.
dsinclair 2014/03/31 20:22:10 Done.
RefPtr<RenderStyle> m_style;

Powered by Google App Engine
This is Rietveld 408576698