Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 2081423004: headless: Add a dedicated child process entrypoint (Closed)

Created:
4 years, 6 months ago by Sami
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Add a dedicated child process entrypoint Add a dedicated entrypoint for transferring control to the headless library in a child process (e.g., a renderer). This avoids the need for the embedder to construct options for the browser, which would get ignored anyway. Embedders should now call headless::RunChildProcessIfNeeded() as soon as possible in their main entrypoint. BUG=595353 Committed: https://crrev.com/7fc3c120cd55159988d6e28620ac7a8e95e901df Cr-Commit-Position: refs/heads/master@{#401260}

Patch Set 1 #

Patch Set 2 : Remove unneccessary include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -14 lines) Patch
M headless/app/headless_shell.cc View 1 chunk +1 line, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.cc View 4 chunks +45 lines, -13 lines 0 comments Download
M headless/public/headless_browser.h View 1 1 chunk +23 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Sami
4 years, 6 months ago (2016-06-22 11:24:58 UTC) #3
alex clarke (OOO till 29th)
lgtm
4 years, 6 months ago (2016-06-22 12:39:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081423004/20001
4 years, 6 months ago (2016-06-22 12:42:09 UTC) #6
Eric Seckler
lgtm
4 years, 6 months ago (2016-06-22 12:43:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 12:46:15 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7fc3c120cd55159988d6e28620ac7a8e95e901df Cr-Commit-Position: refs/heads/master@{#401260}
4 years, 6 months ago (2016-06-22 12:47:27 UTC) #11
altimin
4 years, 6 months ago (2016-06-22 14:22:33 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698