[tools/perf] Enable smoke coverage for all telemetry benchmarks

[tools/perf] Enable smoke coverage for all telemetry benchmarks

BUG=548652

[nednguyen, 2016-06-22 15:54:08]

Description was changed from

==========
[tools/perf] Enable smoke coverage for all telemetry benchmarks

BUG=548652
==========

to

==========
[tools/perf] Enable smoke coverage for all telemetry benchmarks

BUG=548652
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[nednguyen, 2016-06-22 15:54:44]

Description was changed from

==========
[tools/perf] Enable smoke coverage for all telemetry benchmarks

BUG=548652
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
[tools/perf] Enable smoke coverage for all telemetry benchmarks

BUG=548652
==========

[nednguyen, 2016-06-22 18:07:17]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-22 18:08:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081403003/1

[commit-bot: I haz the power, 2016-06-22 19:07:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 19:07:05]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nednguyen, 2016-06-22 20:59:59]

Description was changed from

==========
[tools/perf] Enable smoke coverage for all telemetry benchmarks

BUG=548652
==========

to

==========
[tools/perf] Enable smoke coverage for all telemetry benchmarks

BUG=548652
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[nednguyen, 2016-06-22 21:00:18]

Description was changed from

==========
[tools/perf] Enable smoke coverage for all telemetry benchmarks

BUG=548652
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
[tools/perf] Enable smoke coverage for all telemetry benchmarks

BUG=548652
==========

[nednguyen, 2016-06-22 22:11:45]

Description was changed from

==========
[tools/perf] Enable smoke coverage for all telemetry benchmarks

BUG=548652
==========

to

==========
[tools/perf] Enable smoke coverage for all telemetry benchmarks

BUG=548652
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[nednguyen, 2016-06-22 22:13:39]

Description was changed from

==========
[tools/perf] Enable smoke coverage for all telemetry benchmarks

BUG=548652
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
[tools/perf] Enable smoke coverage for all telemetry benchmarks

BUG=548652
==========

[nednguyen, 2016-06-22 22:17:48]

nednguyen@google.com changed reviewers:
+ dtu@chromium.org, kbr@chromium.org, sullivan@chromium.org

[nednguyen, 2016-06-22 22:17:49]

Not ready to land yet, some issues remain:
1) Some benchmarks are failing due to browser crashes. 
2) Android is not yet sharded, taking 32 minutes in total.

For 1), not sure what is the best way to disable those benchmarks. It's weird
that v8.infinite_scroll is only crashing on cq
(https://chromium-swarm.appspot.com/user/task/2f92d7f81557dd10) and not on the
perf waterfall. Is that because the chromium build on CQ is different from the
one on waterfall?

For 2), Ken: we haven't support sharding for Android yet?

[nednguyen, 2016-06-22 22:44:42]

nednguyen@google.com changed reviewers:
+ jbudorick@chromium.org

[nednguyen, 2016-06-22 22:45:00]

On 2016/06/22 22:17:49, nednguyen wrote:
> Not ready to land yet, some issues remain:
> 1) Some benchmarks are failing due to browser crashes. 
> 2) Android is not yet sharded, taking 32 minutes in total.
> 
> For 1), not sure what is the best way to disable those benchmarks. It's weird
> that v8.infinite_scroll is only crashing on cq
> (https://chromium-swarm.appspot.com/user/task/2f92d7f81557dd10) and not on the
> perf waterfall. Is that because the chromium build on CQ is different from the
> one on waterfall?
> 
> For 2), Ken: we haven't support sharding for Android yet?

+John on the status of sharding Android

[nednguyen, 2016-06-23 03:34:42]

On 2016/06/22 22:17:49, nednguyen wrote:
> Not ready to land yet, some issues remain:
> 1) Some benchmarks are failing due to browser crashes. 

I am suspecting the crash happens because we skip wait action:
https://codereview.chromium.org/2090893002/ may fix it.

[jbudorick, 2016-06-23 10:55:38]

On 2016/06/22 22:45:00, nednguyen wrote:
> On 2016/06/22 22:17:49, nednguyen wrote:
> > Not ready to land yet, some issues remain:
> > 1) Some benchmarks are failing due to browser crashes. 
> > 2) Android is not yet sharded, taking 32 minutes in total.
> > 
> > For 1), not sure what is the best way to disable those benchmarks. It's
weird
> > that v8.infinite_scroll is only crashing on cq
> > (https://chromium-swarm.appspot.com/user/task/2f92d7f81557dd10) and not on
the
> > perf waterfall. Is that because the chromium build on CQ is different from
the
> > one on waterfall?
> > 
> > For 2), Ken: we haven't support sharding for Android yet?
> 
> +John on the status of sharding Android

Ned, I'm not sure what you're asking. It looks like you enabled sharding
yesterday in https://codereview.chromium.org/2089633003

[sullivan, 2016-06-23 12:45:24]

On 2016/06/22 22:17:49, nednguyen wrote:
> Not ready to land yet, some issues remain:
> 1) Some benchmarks are failing due to browser crashes. 
> 2) Android is not yet sharded, taking 32 minutes in total.
> 
> For 1), not sure what is the best way to disable those benchmarks. It's weird
> that v8.infinite_scroll is only crashing on cq
> (https://chromium-swarm.appspot.com/user/task/2f92d7f81557dd10) and not on the
> perf waterfall. Is that because the chromium build on CQ is different from the
> one on waterfall?

The perf waterfall runs release official builds. So there are differences. Maybe
try emailing chrome-windows@ for help?

> For 2), Ken: we haven't support sharding for Android yet?

[nednguyen, 2016-06-23 17:58:59]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 17:59:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081403003/40001

[commit-bot: I haz the power, 2016-06-23 18:49:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 18:49:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nednguyen, 2016-08-02 13:24:30]

nednguyen@google.com changed reviewers:
+ eyaich@chromium.org

[nednguyen, 2016-08-02 13:25:00]

https://codereview.chromium.org/2081403003/diff/40001/tools/perf/BUILD.gn
File tools/perf/BUILD.gn (right):

https://codereview.chromium.org/2081403003/diff/40001/tools/perf/BUILD.gn#new...
tools/perf/BUILD.gn:17: 
+Emily: this CL uncovers some of the missing deps