Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2081393005: Reland of Flip remaining chromium.webrtc* builders to GN. (Closed)

Created:
4 years, 6 months ago by phoglund_chromium
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_skia
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Flip remaining chromium.webrtc* builders to GN. (patchset #1 id:1 of https://codereview.chromium.org/2088343003/ ) Reason for revert: This revert broke the WebRTC win build (?) Original issue's description: > Revert of Flip remaining chromium.webrtc* builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2085873005/ ) > > Reason for revert: > Speculative revert: causes H264 regression (?): https://bugs.chromium.org/p/chromium/issues/detail?id=622632 > > BUG=622632 > > Original issue's description: > > Flip remaining chromium.webrtc* builders to GN. > > > > There are very few GYP builders remaining on the chromium waterfalls; > > all of the main builders have been flipped to GN, so WebRTC should be > > testing that config now. > > > > R=kjellander@chromium.org > > BUG=605318, 618468 > > > > Committed: https://crrev.com/cb929f6769c9a834e5941a2412ec2883b3b162fe > > Cr-Commit-Position: refs/heads/master@{#401327} > > TBR=kjellander@chromium.org,dpranke@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=605318, 618468 TBR=kjellander@chromium.org,dpranke@chromium.org,phoglund@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=622632 Committed: https://crrev.com/f6d02268650a10af563042109968d9f58a43170d Cr-Commit-Position: refs/heads/master@{#401593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M tools/mb/mb_config.pyl View 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
phoglund_chromium
Created Reland of Flip remaining chromium.webrtc* builders to GN.
4 years, 6 months ago (2016-06-23 11:56:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081393005/1
4 years, 6 months ago (2016-06-23 11:57:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081393005/1
4 years, 6 months ago (2016-06-23 13:01:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 13:05:17 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 13:07:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6d02268650a10af563042109968d9f58a43170d
Cr-Commit-Position: refs/heads/master@{#401593}

Powered by Google App Engine
This is Rietveld 408576698