Chromium Code Reviews| Index: chrome/browser/resources/settings/settings_ui/settings_ui.js |
| diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.js b/chrome/browser/resources/settings/settings_ui/settings_ui.js |
| index a6b1008786877c440740f457859cfd2ace456965..3b3ffe23d83db4bd12dfeb4e1153852d14c74b4a 100644 |
| --- a/chrome/browser/resources/settings/settings_ui/settings_ui.js |
| +++ b/chrome/browser/resources/settings/settings_ui/settings_ui.js |
| @@ -31,9 +31,13 @@ Polymer({ |
| 'sideNav.iron-activate': 'onIronActivate_', |
| }, |
| - /** @private */ |
| - onIronActivate_: function() { |
| - this.$$('app-drawer').close(); |
| + /** |
| + * @param {Event} event |
| + * @private |
| + */ |
| + onIronActivate_: function(event) { |
| + if (event.detail.item != this.$$('app-drawer settings-menu').$.advancedPage) |
|
michaelpg
2016/06/22 02:43:00
what about event.detail.item.id != 'advancedPage'?
dschuyler
2016/06/22 23:27:38
Done.
|
| + this.$$('app-drawer').close(); |
| }, |
| /** @private */ |