Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 2081393002: [MD settings] keep drawer open when toggling advanced page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: checking advancedPage Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-ui' implements the UI for the Settings page. 7 * 'settings-ui' implements the UI for the Settings page.
8 * 8 *
9 * Example: 9 * Example:
10 * 10 *
(...skipping 13 matching lines...) Expand all
24 directionDelegate: { 24 directionDelegate: {
25 observer: 'directionDelegateChanged_', 25 observer: 'directionDelegateChanged_',
26 type: Object, 26 type: Object,
27 }, 27 },
28 }, 28 },
29 29
30 listeners: { 30 listeners: {
31 'sideNav.iron-activate': 'onIronActivate_', 31 'sideNav.iron-activate': 'onIronActivate_',
32 }, 32 },
33 33
34 /** @private */ 34 /**
35 onIronActivate_: function() { 35 * @param {Event} event
36 this.$$('app-drawer').close(); 36 * @private
37 */
38 onIronActivate_: function(event) {
39 if (event.detail.item != this.$$('app-drawer settings-menu').$.advancedPage)
michaelpg 2016/06/22 02:43:00 what about event.detail.item.id != 'advancedPage'?
dschuyler 2016/06/22 23:27:38 Done.
40 this.$$('app-drawer').close();
37 }, 41 },
38 42
39 /** @private */ 43 /** @private */
40 onMenuButtonTap_: function() { 44 onMenuButtonTap_: function() {
41 this.$$('app-drawer').toggle(); 45 this.$$('app-drawer').toggle();
42 }, 46 },
43 47
44 /** @private */ 48 /** @private */
45 directionDelegateChanged_: function() { 49 directionDelegateChanged_: function() {
46 this.$$('app-drawer').align = this.directionDelegate.isRtl() ? 50 this.$$('app-drawer').align = this.directionDelegate.isRtl() ?
47 'right' : 'left'; 51 'right' : 'left';
48 }, 52 },
49 }); 53 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698