SoM: Added notice about chromium webkit failures + documentation links.

go/src/infra/appengine/sheriff-o-matic/elements/som-app.html

Index: go/src/infra/appengine/sheriff-o-matic/elements/som-app.html
diff --git a/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html b/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html
index bd77b9f95509ee989e32f55f2fe658cf6cf0d81c..bc53b84093ee45d9a340729f92565855be8e23ed 100644
--- a/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html
+++ b/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html
@@ -54,6 +54,7 @@
         @apply(--layout-vertical);
         margin: 1em;
         border-bottom: 1px solid #ddd;
+        padding-bottom: 10px;

[martiniss, 2016/06/23 01:20:25]

Why did this get added?

       }
       .file-bug,
       .snooze {
@@ -68,6 +69,14 @@
         background: white;
         border-left: 1px solid #ddd;
       }
+      .notification {
+        box-sizing: border-box;
+        width: 100%;
+        padding: 8px 10px;
+        margin: auto;
+        border: 1px solid #666;
+        border-radius: 5px;
+      }
     </style>
     <iron-location id="url" path="{{_path}}"></iron-location>
     <iron-ajax
@@ -109,7 +118,12 @@
         <div class="flex layout vertical">
           <iron-pages attr-for-selected='id' selected="[[_selectedPage]]" class="flex layout vertical">
             <div id="alertsList">
-             <div hidden$="[[_haveAlerts]]">
+              <div class="list-item" hidden$="[[_hideWebkitNotice]]">
+                <div class="notification">
+                  Chromium sheriffs: you now need to handle WebKit bot failures too. <a href="http://www.chromium.org/blink/sheriffing">More information</a>.
+                </div>
+              </div>
+              <div hidden$="[[_haveAlerts]]">
                 No alerts!
               </div>
               <div id="alertsListInner">
@@ -230,6 +244,10 @@
           type: Boolean,
           computed: '_computeHaveAlerts(_alerts)',
         },
+        _hideWebkitNotice: {

[martiniss, 2016/06/23 01:20:25]

Alphabetize

+          type: Boolean,
+          computed: '_computeHideWebkitNotice(_alerts)',
+        },
         _fetchingAlerts: {
           type: Boolean,
           computed: '_computeFetchingAlerts(_activeRequests)',
@@ -436,6 +454,17 @@
         return alerts.length > 0;
       },
 
+      _computeHideWebkitNotice: function(alerts) {
+        if (alerts) {
+          for (var i = 0; i < alerts.length; i++) {

[martiniss, 2016/06/23 01:20:25]

I think there's a fancy for loop you can do, like for x in alerts. But this
works if you need to do it.

+            if (alerts[i].key.indexOf("chromium.webkit") > -1) {

[martiniss, 2016/06/23 01:20:25]

I don't really like this logic being duplicated between here and the alert item.
Not sure if we can avoid this; sean do you know?

[Tiff, 2016/06/23 17:24:57]

One thought I had was to directly add a isWebkitNotice() function to the alerts
objects, but I wasn't sure if this was desirable/what the best way to do this
would be.

+              return false;
+            }
+          }
+        }
+        return true;
+      },
+
       ////////////////////// Annotations ///////////////////////////
 
       _computeAnnotations: function(annotationsJson) {