Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2081333004: Purge FontCache on memory pressure (Closed)

Created:
4 years, 6 months ago by drott
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Purge FontCache on memory pressure BUG=622286 R=bashi,eae,tzik Committed: https://crrev.com/c9d8b3246bd57e05ab5a99ab741f7988f43cd11c Cr-Commit-Position: refs/heads/master@{#401273}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/MemoryCoordinator.cpp View 2 chunks +2 lines, -0 lines 1 comment Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081333004/1
4 years, 6 months ago (2016-06-22 13:09:34 UTC) #2
drott
4 years, 6 months ago (2016-06-22 13:09:39 UTC) #3
eae
LGTM
4 years, 6 months ago (2016-06-22 13:12:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081333004/1
4 years, 6 months ago (2016-06-22 13:12:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 14:26:50 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c9d8b3246bd57e05ab5a99ab741f7988f43cd11c Cr-Commit-Position: refs/heads/master@{#401273}
4 years, 6 months ago (2016-06-22 14:28:20 UTC) #10
bashi
lgtm
4 years, 6 months ago (2016-06-22 22:52:53 UTC) #12
tasak
https://codereview.chromium.org/2081333004/diff/1/third_party/WebKit/Source/core/dom/MemoryCoordinator.cpp File third_party/WebKit/Source/core/dom/MemoryCoordinator.cpp (right): https://codereview.chromium.org/2081333004/diff/1/third_party/WebKit/Source/core/dom/MemoryCoordinator.cpp#newcode36 third_party/WebKit/Source/core/dom/MemoryCoordinator.cpp:36: FontCache::fontCache()->invalidate(); Would you add the following? FontCache::fontCache()->invalidateShapeCache();
4 years, 5 months ago (2016-06-27 06:55:37 UTC) #14
drott
4 years, 5 months ago (2016-06-27 07:07:40 UTC) #15
Message was sent while issue was closed. 
On 2016/06/27 at 06:55:37, tasak wrote:
>
https://codereview.chromium.org/2081333004/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/dom/MemoryCoordinator.cpp (right):
> 
>
https://codereview.chromium.org/2081333004/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/dom/MemoryCoordinator.cpp:36:
FontCache::fontCache()->invalidate();
> Would you add the following?
> FontCache::fontCache()->invalidateShapeCache();

invalidate() calls purge() which calls purgeFallbackListShaperCache(), which is
the same call as from invalidateShapeCache().

Powered by Google App Engine
This is Rietveld 408576698