Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 2081333002: Change value separateor for stsdef to underscore(_) (Closed)

Created:
4 years, 6 months ago by gayane -on leave until 09-2017
Modified:
4 years, 6 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change value separateor for stsdef to underscore(_) BUG=612825 Committed: https://crrev.com/1aa98756f06fb717171b671662dfa57b5faae052 Cr-Commit-Position: refs/heads/master@{#401277}

Patch Set 1 : Change value separateor for stsdef to underscore(_) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/installer/util/channel_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/channel_info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/channel_info_unittest.cc View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
gayane -on leave until 09-2017
PTAL
4 years, 6 months ago (2016-06-21 20:01:57 UTC) #2
grt (UTC plus 2)
lgtm
4 years, 6 months ago (2016-06-22 13:35:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081333002/20001
4 years, 6 months ago (2016-06-22 14:28:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-22 14:33:58 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 14:37:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1aa98756f06fb717171b671662dfa57b5faae052
Cr-Commit-Position: refs/heads/master@{#401277}

Powered by Google App Engine
This is Rietveld 408576698