Reland of Include file names in trace_turbo output

Reland of Include file names in trace_turbo output (patchset #1 id:1 of https://codereview.chromium.org/2083153004/ )

Reason for revert:
Ready to test fix and reland.

Original issue's description:
> Revert of Include file names in trace_turbo output (patchset #3 id:40001 of https://codereview.chromium.org/2083863004/ )
>
> Reason for revert:
> Many build bots are failing with a message of the form:
>
> Missing or invalid v8 JSON file: /tmp/tmp2qcEUy_swarming/0/output.json
>
> Can be relanded once we understand why these failures are occuring.
>
> Original issue's description:
> > Include file names in trace_turbo output
> >
> > The trace turbo output will overwrite itself when functions in different
> > files share the same name. Output files now have the form
> > `turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`.
> >
> > R=ofrobots@google.com
> > BUG=
> >
> > Committed: https://crrev.com/a53b9bf02f31e5647c37e0392afa19f74df1a3ba
> > Cr-Commit-Position: refs/heads/master@{#37199}
>
> TBR=ofrobots@google.com,bmeurer@chromium.org,danno@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://crrev.com/97c2bc362f234bd58515a0faf6af23b4f8ad183a
> Cr-Commit-Position: refs/heads/master@{#37204}

TBR=ofrobots@google.com,bmeurer@chromium.org,danno@chromium.org,machenbach@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Committed: https://crrev.com/9480ea449685fc1efa25e2b97ea063be0e7e10a0
Cr-Commit-Position: refs/heads/master@{#37303}

[mattloring, 2016-06-22 22:59:04]

Created Reland of Include file names in trace_turbo output

[Michael Achenbach, 2016-06-24 09:03:57]

Green light from infra pov. Ass discussed elsewhere, the breakages were possibly
an infra outage.

[ofrobots, 2016-06-27 17:57:39]

https://codereview.chromium.org/2081323007/diff/70001/src/compiler/graph-visu...
File src/compiler/graph-visualizer.cc (right):

https://codereview.chromium.org/2081323007/diff/70001/src/compiler/graph-visu...
src/compiler/graph-visualizer.cc:46: for (int i = 0; i < strlen(source_file);
i++) {
Any way for you to use std::replace like at line 39 below? Otherwise, prefer to
compute strlen outside the loop.

[mattloring, 2016-06-27 18:40:45]

https://codereview.chromium.org/2081323007/diff/70001/src/compiler/graph-visu...
File src/compiler/graph-visualizer.cc (right):

https://codereview.chromium.org/2081323007/diff/70001/src/compiler/graph-visu...
src/compiler/graph-visualizer.cc:46: for (int i = 0; i < strlen(source_file);
i++) {
On 2016/06/27 17:57:39, ofrobots wrote:
> Any way for you to use std::replace like at line 39 below? Otherwise, prefer
to
> compute strlen outside the loop.

Updated to use std::replace.

[ofrobots, 2016-06-27 21:49:49]

lgtm

[mattloring, 2016-06-27 21:50:51]

The CQ bit was checked by mattloring@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 21:50:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 21:51:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 21:51:02]

Dry run: This issue passed the CQ dry run.

[mattloring, 2016-06-27 22:02:50]

The CQ bit was checked by mattloring@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 22:02:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 22:03:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 22:03:03]

Dry run: This issue passed the CQ dry run.

[mattloring, 2016-06-28 00:01:28]

The CQ bit was checked by mattloring@google.com

[mattloring, 2016-06-28 00:01:29]

The patchset sent to the CQ was uploaded after l-g-t-m from ofrobots@google.com
Link to the patchset: https://codereview.chromium.org/2081323007/#ps110001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-28 00:01:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 00:02:13]

Committed patchset #4 (id:110001)

[commit-bot: I haz the power, 2016-06-28 00:04:44]

Description was changed from

==========
Reland of Include file names in trace_turbo output (patchset #1 id:1 of
https://codereview.chromium.org/2083153004/ )

Reason for revert:
Ready to test fix and reland.

Original issue's description:
> Revert of Include file names in trace_turbo output (patchset #3 id:40001 of
https://codereview.chromium.org/2083863004/ )
> 
> Reason for revert:
> Many build bots are failing with a message of the form:
> 
> Missing or invalid v8 JSON file: /tmp/tmp2qcEUy_swarming/0/output.json
> 
> Can be relanded once we understand why these failures are occuring.
> 
> Original issue's description:
> > Include file names in trace_turbo output
> >
> > The trace turbo output will overwrite itself when functions in different
> > files share the same name. Output files now have the form
> > `turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`.
> >
> > R=ofrobots@google.com
> > BUG=
> >
> > Committed: https://crrev.com/a53b9bf02f31e5647c37e0392afa19f74df1a3ba
> > Cr-Commit-Position: refs/heads/master@{#37199}
> 
> TBR=ofrobots@google.com,bmeurer@chromium.org,danno@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
> 
> Committed: https://crrev.com/97c2bc362f234bd58515a0faf6af23b4f8ad183a
> Cr-Commit-Position: refs/heads/master@{#37204}

TBR=ofrobots@google.com,bmeurer@chromium.org,danno@chromium.org,machenbach@go...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
==========

to

==========
Reland of Include file names in trace_turbo output (patchset #1 id:1 of
https://codereview.chromium.org/2083153004/ )

Reason for revert:
Ready to test fix and reland.

Original issue's description:
> Revert of Include file names in trace_turbo output (patchset #3 id:40001 of
https://codereview.chromium.org/2083863004/ )
>
> Reason for revert:
> Many build bots are failing with a message of the form:
>
> Missing or invalid v8 JSON file: /tmp/tmp2qcEUy_swarming/0/output.json
>
> Can be relanded once we understand why these failures are occuring.
>
> Original issue's description:
> > Include file names in trace_turbo output
> >
> > The trace turbo output will overwrite itself when functions in different
> > files share the same name. Output files now have the form
> > `turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`.
> >
> > R=ofrobots@google.com
> > BUG=
> >
> > Committed: https://crrev.com/a53b9bf02f31e5647c37e0392afa19f74df1a3ba
> > Cr-Commit-Position: refs/heads/master@{#37199}
>
> TBR=ofrobots@google.com,bmeurer@chromium.org,danno@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://crrev.com/97c2bc362f234bd58515a0faf6af23b4f8ad183a
> Cr-Commit-Position: refs/heads/master@{#37204}

TBR=ofrobots@google.com,bmeurer@chromium.org,danno@chromium.org,machenbach@go...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Committed: https://crrev.com/9480ea449685fc1efa25e2b97ea063be0e7e10a0
Cr-Commit-Position: refs/heads/master@{#37303}
==========

[commit-bot: I haz the power, 2016-06-28 00:04:46]

Patchset 4 (id:??) landed as
https://crrev.com/9480ea449685fc1efa25e2b97ea063be0e7e10a0
Cr-Commit-Position: refs/heads/master@{#37303}