Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2081263002:
Add UseCounter for CSP referrer directive (Closed)
|
Created:
4 years, 6 months ago by estark Modified:
4 years, 6 months ago CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, mkwst+watchlist-csp_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd UseCounter for CSP referrer directive
The 'referrer' directive hasn't been implemented by other
browsers, and is being replaced by the Referrer-Policy
header, so we'd like to remove it if we can.
BUG=621219
Committed: https://crrev.com/e0c6be7ac3d7c4127d2bf3badb55db9d2f52bc33
Cr-Commit-Position: refs/heads/master@{#401814}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : rebase again #
Messages
Total messages: 37 (20 generated)
Description was changed from ========== Add UseCounter for CSP referrer directive BUG=621219 ========== to ========== Add UseCounter for CSP referrer directive The 'referrer' directive hasn't been implemented by other browsers, and is being replaced by the Referrer-Policy header, so we'd like to remove it if we can. BUG=621219 ==========
estark@chromium.org changed reviewers: + mkwst@chromium.org
The CQ bit was checked by estark@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081263002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
Description was changed from ========== Add UseCounter for CSP referrer directive The 'referrer' directive hasn't been implemented by other browsers, and is being replaced by the Referrer-Policy header, so we'd like to remove it if we can. BUG=621219 ========== to ========== Add UseCounter for CSP referrer directive The 'referrer' directive hasn't been implemented by other browsers, and is being replaced by the Referrer-Policy header, so we'd like to remove it if we can. BUG=621219 TBR=mkwst@chromium.org ==========
estark@chromium.org changed reviewers: + holte@chromium.org
holte@, can you please review histograms.xml? TBRing mkwst per lgtm received via twitter :) https://twitter.com/mikewest/status/745641594989187073
Real, live LGTM. Not via Twitter, but via this amazing interface that I can't use from my iPhone.
lgtm
Description was changed from ========== Add UseCounter for CSP referrer directive The 'referrer' directive hasn't been implemented by other browsers, and is being replaced by the Referrer-Policy header, so we'd like to remove it if we can. BUG=621219 TBR=mkwst@chromium.org ========== to ========== Add UseCounter for CSP referrer directive The 'referrer' directive hasn't been implemented by other browsers, and is being replaced by the Referrer-Policy header, so we'd like to remove it if we can. BUG=621219 ==========
The CQ bit was checked by estark@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081263002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
The CQ bit was checked by estark@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org, holte@chromium.org Link to the patchset: https://codereview.chromium.org/2081263002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081263002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h:
While running git apply --index -3 -p1;
error: patch failed: third_party/WebKit/Source/core/frame/UseCounter.h:1221
Falling back to three-way merge...
Applied patch to 'third_party/WebKit/Source/core/frame/UseCounter.h' with
conflicts.
U third_party/WebKit/Source/core/frame/UseCounter.h
Patch: third_party/WebKit/Source/core/frame/UseCounter.h
Index: third_party/WebKit/Source/core/frame/UseCounter.h
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.h
b/third_party/WebKit/Source/core/frame/UseCounter.h
index
728d184ef29d211bc01997fbc6a3b63b450bb7f7..ae133fbbd36c34bf1ca6ea55b5e7c9149a2bca28
100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.h
+++ b/third_party/WebKit/Source/core/frame/UseCounter.h
@@ -1221,6 +1221,7 @@ public:
CrossOriginWindowPrint = 1414,
MediaStreamOnActive = 1415,
MediaStreamOnInactive = 1416,
+ CSPReferrerDirective = 1417,
// Add new features immediately above this line. Don't change assigned
// numbers of any item, and don't reuse removed slots.
The CQ bit was checked by estark@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org, holte@chromium.org Link to the patchset: https://codereview.chromium.org/2081263002/#ps60001 (title: "rebase again")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081263002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by estark@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081263002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by estark@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081263002/60001
Message was sent while issue was closed.
Description was changed from ========== Add UseCounter for CSP referrer directive The 'referrer' directive hasn't been implemented by other browsers, and is being replaced by the Referrer-Policy header, so we'd like to remove it if we can. BUG=621219 ========== to ========== Add UseCounter for CSP referrer directive The 'referrer' directive hasn't been implemented by other browsers, and is being replaced by the Referrer-Policy header, so we'd like to remove it if we can. BUG=621219 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add UseCounter for CSP referrer directive The 'referrer' directive hasn't been implemented by other browsers, and is being replaced by the Referrer-Policy header, so we'd like to remove it if we can. BUG=621219 ========== to ========== Add UseCounter for CSP referrer directive The 'referrer' directive hasn't been implemented by other browsers, and is being replaced by the Referrer-Policy header, so we'd like to remove it if we can. BUG=621219 Committed: https://crrev.com/e0c6be7ac3d7c4127d2bf3badb55db9d2f52bc33 Cr-Commit-Position: refs/heads/master@{#401814} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/e0c6be7ac3d7c4127d2bf3badb55db9d2f52bc33 Cr-Commit-Position: refs/heads/master@{#401814} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
