Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 2081253002: Implement rudimentary touchscreen support in mus. (Closed)

Created:
4 years, 6 months ago by kylechar
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement rudimentary touchscreen support in mus. Add TouchController class that implements rudimentary touchscreen support in mus. When there is 1 display and 1 touchscreen input-device it matches them up and populates the relevant transform. Small modifications to mus::Display and mus::PlatformDisplay to store the display id and plumb display id and display size back out. Change PlatformScreen implementation to call NativeDisplayDelegate::GetDisplays() after a new display is added. If this doesn't happen the list of DisplaySnapshots stored in Ozone isn't updated and incomplete information is included with touch events. BUG=601074 TEST=Touch works on Pixel. Committed: https://crrev.com/c97cdcc4d02b8823790798f2e812d933a4045a03 Cr-Commit-Position: refs/heads/master@{#401285}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add TODO. #

Patch Set 3 : Add missing pure virtual. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -19 lines) Patch
M components/mus/mus_app.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/mus/mus_app.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M components/mus/ws/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M components/mus/ws/display.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/mus/ws/display.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M components/mus/ws/platform_display.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M components/mus/ws/platform_display.cc View 2 chunks +6 lines, -1 line 0 comments Download
M components/mus/ws/platform_screen_impl_ozone.h View 1 chunk +8 lines, -0 lines 0 comments Download
M components/mus/ws/platform_screen_impl_ozone.cc View 3 chunks +27 lines, -18 lines 0 comments Download
M components/mus/ws/test_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
A components/mus/ws/touch_controller.h View 1 chunk +37 lines, -0 lines 0 comments Download
A components/mus/ws/touch_controller.cc View 1 1 chunk +105 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
kylechar
4 years, 6 months ago (2016-06-21 17:49:30 UTC) #4
sky
LGTM https://codereview.chromium.org/2081253002/diff/1/components/mus/ws/touch_controller.cc File components/mus/ws/touch_controller.cc (right): https://codereview.chromium.org/2081253002/diff/1/components/mus/ws/touch_controller.cc#newcode80 components/mus/ws/touch_controller.cc:80: if (touch_displays.size() == 1 && touch_devices.size() == 1) ...
4 years, 6 months ago (2016-06-21 20:09:22 UTC) #6
kylechar
Thanks sky! https://codereview.chromium.org/2081253002/diff/1/components/mus/ws/touch_controller.cc File components/mus/ws/touch_controller.cc (right): https://codereview.chromium.org/2081253002/diff/1/components/mus/ws/touch_controller.cc#newcode80 components/mus/ws/touch_controller.cc:80: if (touch_displays.size() == 1 && touch_devices.size() == ...
4 years, 6 months ago (2016-06-22 12:47:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081253002/20001
4 years, 6 months ago (2016-06-22 12:48:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/243293)
4 years, 6 months ago (2016-06-22 13:15:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081253002/40001
4 years, 6 months ago (2016-06-22 13:37:27 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-22 15:33:47 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 15:35:35 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c97cdcc4d02b8823790798f2e812d933a4045a03
Cr-Commit-Position: refs/heads/master@{#401285}

Powered by Google App Engine
This is Rietveld 408576698