Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2081233002: Fix a V8 5.1 backwards compatibility (Closed)

Created:
4 years, 6 months ago by eostroukhov-old
Modified:
4 years, 6 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a V8 5.1 backwards compatibility R=dgozman@chromium.org BUG= Committed: https://crrev.com/cd2eb18fb1c497ae4fd8dc90f275c27ebdabfa9f Cr-Commit-Position: refs/heads/master@{#401061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/v8_inspector/V8Compat.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081233002/1
4 years, 6 months ago (2016-06-21 17:05:56 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-21 17:05:58 UTC) #4
pfeldman
lgtm
4 years, 6 months ago (2016-06-21 17:14:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081233002/1
4 years, 6 months ago (2016-06-21 17:29:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 18:59:33 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 19:08:55 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cd2eb18fb1c497ae4fd8dc90f275c27ebdabfa9f
Cr-Commit-Position: refs/heads/master@{#401061}

Powered by Google App Engine
This is Rietveld 408576698