Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 208123002: Disable the globals instrumentation under asan==1, not asan_coverage==1. (Closed)

Created:
6 years, 9 months ago by Alexander Potapenko
Modified:
6 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Disable the globals instrumentation under asan==1, not asan_coverage==1. BUG=352073 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258636

Patch Set 1 #

Patch Set 2 : Removed <(chroot_cmd) #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/linux/system.gyp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Alexander Potapenko
TBR
6 years, 9 months ago (2014-03-21 12:02:58 UTC) #1
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 9 months ago (2014-03-21 12:03:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/208123002/1
6 years, 9 months ago (2014-03-21 12:03:24 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 12:22:05 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 9 months ago (2014-03-21 12:22:06 UTC) #5
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 9 months ago (2014-03-21 12:34:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/208123002/1
6 years, 9 months ago (2014-03-21 12:35:07 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 13:25:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-21 13:25:01 UTC) #9
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 9 months ago (2014-03-21 16:58:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/208123002/1
6 years, 9 months ago (2014-03-21 16:58:45 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 18:51:22 UTC) #12
Message was sent while issue was closed. 
Change committed as 258636

Powered by Google App Engine
This is Rietveld 408576698