Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2081223003: Subzero: Fix Makefile.standalone to enable format with --host-flavor=debug flag (Closed)

Created:
4 years, 6 months ago by obucinac
Modified:
4 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix Makefile.standalone to enable format with DEBUG flag When building pnacl with --host-flavor=debug, tools at ../../out/llvm_x86_64_linux_work/Release+Asserts/bin are not available, so we need a fix to enable source code formatting with tools from ../../out/llvm_x86_64_linux_debug_work/Debug+Asserts/bin R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2d152e354512b58c5f81ad10791abaa2c6ce79e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Makefile.standalone View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
obucinac
4 years, 6 months ago (2016-06-22 13:32:37 UTC) #3
Jim Stichnoth
LGTM. (I went ahead and fixed the 80-col problems.)
4 years, 6 months ago (2016-06-22 16:03:09 UTC) #4
Jim Stichnoth
4 years, 6 months ago (2016-06-22 16:04:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2d152e354512b58c5f81ad10791abaa2c6ce79e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698