Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2081203003: Fix for running Chrome under a service token. This patch fixes an issue with the handling of the de… (Closed)

Created:
4 years, 6 months ago by forshaw
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fix for running Chrome under a service token. This patch fixes an issue with the handling of the default DACL when running Chrome under a service token, such as Local System. These tokens don't always have an assigned logon session SID, which would cause the DACL lockdown process to fail. BUG=615396 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng TEST=1. Download PSTools from https://technet.microsoft.com/en-us/sysinternals/pstools.aspx 2. Run cmd.exe as an administrator 3. Run the command 'psexec -s -i c:\path\to\chrome.exe' 4. Verify that the browser is useable Review-Url: https://codereview.chromium.org/2061703002 Cr-Commit-Position: refs/heads/master@{#399529} (cherry picked from commit 6ac615dfd11e86b1ce7766e1de263ce3d2e3b727) Committed: https://chromium.googlesource.com/chromium/src/+/f6ba15785561d8ee4146c589fbb4b77b6c20e02b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M sandbox/win/src/acl.cc View 1 chunk +5 lines, -1 line 0 comments Download
M sandbox/win/src/restricted_token_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
forshaw
4 years, 6 months ago (2016-06-21 16:56:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f6ba15785561d8ee4146c589fbb4b77b6c20e02b.

Powered by Google App Engine
This is Rietveld 408576698