Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2081193002: Count usage of MediaStream active and inactive events (Closed)

Created:
4 years, 6 months ago by Guido Urdaneta
Modified:
4 years, 6 months ago
Reviewers:
Steven Holte, foolip
CC:
chromium-reviews, blink-reviews, haraken, tommyw+watchlist_chromium.org, asvitkine+watch_chromium.org, mcasas+watch+mediastream_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Count usage of MediaStream active and inactive events BUG=621913 Committed: https://crrev.com/85b0410d2fd19498da09684ca33c47d06aa44ff7 Cr-Commit-Position: refs/heads/master@{#401345}

Patch Set 1 #

Total comments: 1

Patch Set 2 : foolip comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
Guido Urdaneta
holte@chromium.org: please review changes in histogram.xml foolip@chromium.org: please review changes in WebKit
4 years, 6 months ago (2016-06-21 13:58:53 UTC) #4
Steven Holte
lgtm
4 years, 6 months ago (2016-06-21 17:55:27 UTC) #5
foolip
https://codereview.chromium.org/2081193002/diff/1/third_party/WebKit/Source/modules/mediastream/MediaStream.idl File third_party/WebKit/Source/modules/mediastream/MediaStream.idl (right): https://codereview.chromium.org/2081193002/diff/1/third_party/WebKit/Source/modules/mediastream/MediaStream.idl#newcode48 third_party/WebKit/Source/modules/mediastream/MediaStream.idl:48: [MeasureAs=MediaStreamOnActive] attribute EventHandler onactive; I think you shouldn't actually ...
4 years, 6 months ago (2016-06-22 12:17:05 UTC) #6
Guido Urdaneta
On 2016/06/22 12:17:05, Philip Jägenstedt wrote: > https://codereview.chromium.org/2081193002/diff/1/third_party/WebKit/Source/modules/mediastream/MediaStream.idl > File third_party/WebKit/Source/modules/mediastream/MediaStream.idl (right): > > https://codereview.chromium.org/2081193002/diff/1/third_party/WebKit/Source/modules/mediastream/MediaStream.idl#newcode48 ...
4 years, 6 months ago (2016-06-22 13:50:37 UTC) #7
foolip
lgtm
4 years, 6 months ago (2016-06-22 14:56:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081193002/20001
4 years, 6 months ago (2016-06-22 15:59:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/24852) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-22 16:02:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081193002/40001
4 years, 6 months ago (2016-06-22 16:12:14 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-22 18:11:23 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 18:17:02 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/85b0410d2fd19498da09684ca33c47d06aa44ff7
Cr-Commit-Position: refs/heads/master@{#401345}

Powered by Google App Engine
This is Rietveld 408576698