Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: tools/testing/dart/test_progress.dart

Issue 2081173002: Add suppression to test.dart for flaky content_shell crashes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_configurations.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_progress.dart
diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart
index 3fdfbf3fa734a438dbf45bd27b96aa0c6ec35b84..b93294b389b0a3348edc9a2625fb281e195d8547 100644
--- a/tools/testing/dart/test_progress.dart
+++ b/tools/testing/dart/test_progress.dart
@@ -174,6 +174,31 @@ class ExitCodeSetter extends EventListener {
}
}
+class IgnoredTestMonitor extends EventListener {
+ static final int maxIgnored = 5;
+
+ int countIgnored = 0;
+
+ void done(TestCase test) {
+ if (test.lastCommandOutput.result(test) == Expectation.IGNORE) {
+ countIgnored++;
+ if (countIgnored > maxIgnored) {
+ print("/nMore than $maxIgnored tests were ignored due to flakes in");
+ print("the test infrastructure. Notify whesse@google.com.");
+ print("Output of the last ignored test was:");
+ print(_buildFailureOutput(test));
+ exit(1);
+ }
+ }
+ }
+
+ void allDone() {
+ if (countIgnored > 0) {
+ print("Ignored $countIgnored tests due to flaky infrastructure");
+ }
+ }
+}
+
class FlakyLogWriter extends EventListener {
void done(TestCase test) {
if (test.isFlaky && test.result != Expectation.PASS) {
« no previous file with comments | « tools/testing/dart/test_configurations.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698