Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: tools/testing/dart/status_file_parser.dart

Issue 2081173002: Add suppression to test.dart for flaky content_shell crashes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/browser_controller.dart ('k') | tools/testing/dart/test_configurations.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/status_file_parser.dart
diff --git a/tools/testing/dart/status_file_parser.dart b/tools/testing/dart/status_file_parser.dart
index 8fa9bb7dda2ddc3016ecf04d04fee1d2667d3b5d..c4be8017191523a5e3afe638929c6032ac23ac35 100644
--- a/tools/testing/dart/status_file_parser.dart
+++ b/tools/testing/dart/status_file_parser.dart
@@ -35,6 +35,11 @@ class Expectation {
static Expectation SKIP_SLOW = byName('SkipSlow');
static Expectation SKIP_BY_DESIGN = byName('SkipByDesign');
+ // Can be returned by the test runner to say the result should be ignored,
+ // and assumed to meet the expectations, due to an infrastructure failure.
+ // Do not place in status files.
+ static Expectation IGNORE = byName('Ignore');
+
static Expectation byName(String name) {
_initialize();
name = name.toLowerCase();
@@ -77,6 +82,7 @@ class Expectation {
build("SkipSlow", group: skip, isMetaExpectation: true);
build("Ok", isMetaExpectation: true);
build("Slow", isMetaExpectation: true);
+ build("Ignore");
}
}
@@ -94,6 +100,7 @@ class Expectation {
bool canBeOutcomeOf(Expectation expectation) {
Expectation outcome = this;
+ if (outcome == IGNORE) return true;
while (outcome != null) {
if (outcome == expectation) {
return true;
« no previous file with comments | « tools/testing/dart/browser_controller.dart ('k') | tools/testing/dart/test_configurations.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698