Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2081163002: [ast] Remove unused function Scope::ReportMessage. (Closed)

Created:
4 years, 6 months ago by neis
Modified:
4 years, 5 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ast] Remove unused function Scope::ReportMessage. R=adamk@chromium.org BUG= Committed: https://crrev.com/b35623cab337e528a46e53f26d9286b0f826655c Cr-Commit-Position: refs/heads/master@{#37280}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M src/ast/scopes.h View 1 chunk +0 lines, -5 lines 2 comments Download
M src/ast/scopes.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
neis
4 years, 6 months ago (2016-06-21 13:23:02 UTC) #1
adamk
lgtm, with a few more things you can delete https://codereview.chromium.org/2081163002/diff/1/src/ast/scopes.h File src/ast/scopes.h (right): https://codereview.chromium.org/2081163002/diff/1/src/ast/scopes.h#newcode10 src/ast/scopes.h:10: ...
4 years, 6 months ago (2016-06-21 16:30:31 UTC) #2
neis
On 2016/06/21 16:30:31, adamk wrote: > lgtm, with a few more things you can delete ...
4 years, 5 months ago (2016-06-27 09:07:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2081163002/1
4 years, 5 months ago (2016-06-27 09:07:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 09:36:22 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 09:38:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b35623cab337e528a46e53f26d9286b0f826655c
Cr-Commit-Position: refs/heads/master@{#37280}

Powered by Google App Engine
This is Rietveld 408576698