[Offline Page] Offline page sharing implementation

chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index 536f4666a720e64511efbce5286b0d4527fa0cce..87978640355a337712a2fb8037ff66a53f1625c1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -84,6 +84,7 @@ import org.chromium.chrome.browser.metrics.UmaUtils;
 import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
 import org.chromium.chrome.browser.nfc.BeamController;
 import org.chromium.chrome.browser.nfc.BeamProvider;
+import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
 import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
 import org.chromium.chrome.browser.omaha.UpdateMenuItemHelper;
 import org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup;
@@ -959,26 +960,37 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
 
         final Activity mainActivity = this;
         ContentBitmapCallback callback = new ContentBitmapCallback() {
-                    @Override
-                    public void onFinishGetBitmap(Bitmap bitmap, int response) {
-                        // Check whether this page is an offline page, and use its online URL if so.
-                        String url = currentTab.getOfflinePageOriginalUrl();
-                        RecordHistogram.recordBooleanHistogram(
-                                "OfflinePages.SharedPageWasOffline", url != null);
-
-                        // If there is no entry in the offline pages DB for this tab, use the tab's
-                        // URL directly.
-                        if (url == null) url = currentTab.getUrl();
-
-                        ShareHelper.share(
-                                shareDirectly, mainActivity, currentTab.getTitle(), url, bitmap);
-                        if (shareDirectly) {
-                            RecordUserAction.record("MobileMenuDirectShare");
-                        } else {
-                            RecordUserAction.record("MobileMenuShare");
-                        }
+            @Override
+            public void onFinishGetBitmap(Bitmap bitmap, int response) {
+                // Check whether this page is an offline page, and use its online URL if so.
+                String url = currentTab.getOfflinePageOriginalUrl();
+                RecordHistogram.recordBooleanHistogram(
+                        "OfflinePages.SharedPageWasOffline", url != null);
+                boolean offlinePageSharing =

[fgorski, 2016/06/28 20:03:22]

rename to isOfflinePageSharingEnabled, please

[Vivian, 2016/07/27 23:44:10]

Done.

+                        (url != null && OfflinePageBridge.isPageSharingEnabled());
+
+                if (!offlinePageSharing) {
+                    // If there is no entry in the offline pages DB for this tab, use the
+                    // tab's URL directly.
+                    if (url == null) url = currentTab.getUrl();
+
+                    ShareHelper.share(
+                            shareDirectly, mainActivity, currentTab.getTitle(), url, null, bitmap);
+                    if (shareDirectly) {
+                        RecordUserAction.record("MobileMenuDirectShare");
+                    } else {
+                        RecordUserAction.record("MobileMenuShare");
                     }
-                };
+                } else {
+                    // This is for experienmental feature Offline Page Sharing.

[dewittj, 2016/06/28 16:45:25]

This feature is embedded enough in sharing and has enough questions about
implementation that I'd love to see you write up a document about what you're
going to do, and how  you're going to do it, before requesting a code review. 
Some things that would be useful to share in a document to gain consensus:
* Where to put the copies of offline pages that are prepped for sharing, how
they get cleaned up, how many copies you expect to have at one time.
* How this will interact with the other 2 things we currently share (URL and
screenshot)
* How to surface sharing errors if file copy fails
* How to organize the code better (today it is all spaghetti code, and that is
partly the fault of the Bitmap implementation.  We could do better and probably
should clean it up as a part of your change.)

Does that make sense?

[Vivian, 2016/07/27 23:44:10]

Acknowledged.

+                    // If this page is an offline page, and the share the offline page
+                    // instead of url.
+                    Context mContext = getApplicationContext();
+                    OfflinePageUtils.shareOfflinePage(
+                            shareDirectly, mainActivity, url, bitmap, mContext, currentTab);
+                }
+            }
+        };
         if (isIncognito || currentTab.getWebContents() == null) {
             callback.onFinishGetBitmap(null, ReadbackResponse.SURFACE_UNAVAILABLE);
         } else {