chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java - Issue 2081153005: [Offline Page] Offline page sharing implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

Issue 2081153005: [Offline Page] Offline page sharing implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge CL Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageItem.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

index 9e195bcd6030e0ed6282d4740642200a147ccbf3..3a93a102530436ff570b1f2f7a4f9357eab9246e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

@@ -91,6 +91,8 @@ public class OfflinePageUtils {

public void onSavePageDone(int savePageResult, String url, long offlineId) {

// TODO(fgorski): Decide if we need to do anything with result.

// Perhaps some UMA reporting, but that can really happen someplace else.

+ if (!OfflinePageBridge.isPageSharingEnabled()) return;

fgorski 2016/06/23 17:41:11 I don't think I understand that one. Please explai

Vivian 2016/06/27 16:56:08 This line is unused. Removed it.

}

});

}