[Offline Page] Offline page sharing implementation

chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.offlinepages;
 
 import android.content.Context;
 import android.os.Environment;
 import android.test.suitebuilder.annotation.SmallTest;
 
 import org.chromium.base.Callback;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.test.util.CommandLineFlags;
 import org.chromium.chrome.browser.ChromeActivity;
 import org.chromium.chrome.browser.offlinepages.OfflinePageBridge.OfflinePageModelObserver;
 import org.chromium.chrome.browser.offlinepages.OfflinePageBridge.SavePageCallback;
 import org.chromium.chrome.browser.profiles.Profile;
 import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.test.ChromeActivityTestCaseBase;
 import org.chromium.components.offlinepages.SavePageResult;
 import org.chromium.content.browser.test.util.Criteria;
 import org.chromium.content.browser.test.util.CriteriaHelper;
 import org.chromium.net.ConnectionType;
 import org.chromium.net.NetworkChangeNotifier;
 import org.chromium.net.test.EmbeddedTestServer;
 
+import java.io.File;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.UUID;
 import java.util.concurrent.Semaphore;
 import java.util.concurrent.TimeUnit;
 
 /** Unit tests for {@link OfflinePageUtils}. */
 @CommandLineFlags.Add("enable-features=OfflineBookmarks")
 public class OfflinePageUtilsTest extends ChromeActivityTestCaseBase<ChromeActivity> {
     private static final String TEST_PAGE = "/chrome/test/data/android/about.html";
     private static final int TIMEOUT_MS = 5000;
     private static final ClientId BOOKMARK_ID =
             new ClientId(OfflinePageBridge.BOOKMARK_NAMESPACE, "1234");
@@ skipping 189 matching lines @@
                     public void onResult(List<OfflinePageItem> allPages) {
                         result.addAll(allPages);
                         semaphore.release();
                     }
                 });
             }
         });
         assertTrue(semaphore.tryAcquire(TIMEOUT_MS, TimeUnit.MILLISECONDS));
         return result;
     }
+
+    @SmallTest
+    public void testCopyToShareableLocation() throws Exception {
+        // Save an offline page.
+        String testUrl = mTestServer.getURL(TEST_PAGE);

[Theresa, 2016/08/15 20:50:00]

It looks like the code to save an offline page is used in 3 places. I think it
makes sense to pull it out into a helper method.

[Vivian, 2016/08/16 17:40:12]

Done.

+        loadUrl(testUrl);
+        savePage(SavePageResult.SUCCESS, testUrl);
+
+        // Get an offline page from the list and obtain the file path.
+        List<OfflinePageItem> allPages = getAllPages();
+        OfflinePageItem offlinePage = allPages.get(0);
+        String offlinePageFilePath = offlinePage.getFilePath();
+
+        File offlinePageOriginal = new File(offlinePageFilePath);
+
+        // Clear the directory before perform file copying.
+        Context context = getActivity().getBaseContext();
+        OfflinePageUtils.clearSharedOfflineFiles(context);
+
+        File offlineCacheDir =
+                OfflinePageUtils.getDirectoryForOfflineSharing(getActivity().getBaseContext());
+
+        boolean success = (offlineCacheDir != null);
+        assertTrue("Should be able to create subdirectory in shareable directory.", success);
+
+        // Use a random file name for test issue.

[Theresa, 2016/08/15 20:50:00]

What is the test issue that requires using a random file name?

[Vivian, 2016/08/16 17:40:12]

This is deprecated after adding clearing directory before copying. Changed back
to original file name.

+        File offlinePageShareable = new File(offlineCacheDir, UUID.randomUUID().toString());
+
+        assertFalse("Should not exist a file with same file name,", offlinePageShareable.exists());

[Theresa, 2016/08/15 20:50:00]

"The shareable offline page file should lot already exist."

[Vivian, 2016/08/16 17:40:12]

Done.

+        assertTrue("Should be able to copy file to shareable location.",
+                OfflinePageUtils.copyToShareableLocation(
+                        offlinePageOriginal, offlinePageShareable));
+        assertEquals("File copy result incorrect", offlinePageOriginal.length(),
+                offlinePageShareable.length());
+    }
+
+    @SmallTest
+    public void testDeleteSharedOfflineFiles() throws Exception {
+        // Save an offline page.
+        String testUrl = mTestServer.getURL(TEST_PAGE);
+        loadUrl(testUrl);
+        savePage(SavePageResult.SUCCESS, testUrl);
+
+        // Copies file to external cache directory.
+        List<OfflinePageItem> allPages = getAllPages();
+        OfflinePageItem offlinePage = allPages.get(0);
+        String offlinePageFilePath = offlinePage.getFilePath();
+
+        File offlinePageOriginal = new File(offlinePageFilePath);
+
+        File offlineCacheDir =
+                OfflinePageUtils.getDirectoryForOfflineSharing(getActivity().getBaseContext());
+
+        boolean success = (offlineCacheDir != null);
+        assertTrue("Should be able to create subdirectory in shareable directory.", success);
+
+        File offlinePageShareable = new File(offlineCacheDir, offlinePageOriginal.getName());
+        if (!offlinePageShareable.exists()) {
+            assertTrue("Should be able to copy file to shareable location.",
+                    OfflinePageUtils.copyToShareableLocation(
+                            offlinePageOriginal, offlinePageShareable));
+        }
+
+        // Clear files.
+        Context context = getActivity().getBaseContext();
+        OfflinePageUtils.clearSharedOfflineFiles(context);
+
+        assertFalse("Chache directory should be deleted.", offlineCacheDir.exists());
+    }
 }