[Offline Page] Offline page sharing implementation

chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
@@ skipping 23 matching lines @@
 import android.view.Window;
 import android.view.WindowManager;
 import android.view.accessibility.AccessibilityManager;
 import android.view.accessibility.AccessibilityManager.AccessibilityStateChangeListener;
 import android.view.accessibility.AccessibilityManager.TouchExplorationStateChangeListener;
 
 import org.chromium.base.ActivityState;
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.ApplicationStatus;
 import org.chromium.base.BaseSwitches;
+import org.chromium.base.Callback;
 import org.chromium.base.CommandLine;
 import org.chromium.base.SysUtils;
 import org.chromium.base.TraceEvent;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.base.metrics.RecordUserAction;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.IntentHandler.IntentHandlerDelegate;
 import org.chromium.chrome.browser.IntentHandler.TabOpenType;
 import org.chromium.chrome.browser.appmenu.AppMenu;
@@ skipping 23 matching lines @@
 import org.chromium.chrome.browser.help.HelpAndFeedback;
 import org.chromium.chrome.browser.infobar.InfoBarContainer;
 import org.chromium.chrome.browser.init.AsyncInitializationActivity;
 import org.chromium.chrome.browser.metrics.LaunchMetrics;
 import org.chromium.chrome.browser.metrics.StartupMetrics;
 import org.chromium.chrome.browser.metrics.UmaSessionStats;
 import org.chromium.chrome.browser.metrics.UmaUtils;
 import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
 import org.chromium.chrome.browser.nfc.BeamController;
 import org.chromium.chrome.browser.nfc.BeamProvider;
+import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
+import org.chromium.chrome.browser.offlinepages.OfflinePageItem;
 import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
 import org.chromium.chrome.browser.omaha.UpdateMenuItemHelper;
 import org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup;
 import org.chromium.chrome.browser.partnercustomizations.PartnerBrowserCustomizations;
 import org.chromium.chrome.browser.preferences.ChromePreferenceManager;
 import org.chromium.chrome.browser.preferences.PrefServiceBridge;
 import org.chromium.chrome.browser.preferences.PreferencesLauncher;
 import org.chromium.chrome.browser.printing.TabPrinter;
 import org.chromium.chrome.browser.share.ShareHelper;
 import org.chromium.chrome.browser.snackbar.DataUseSnackbarController;
@@ skipping 855 matching lines @@
      * @param shareDirectly Whether it should share directly with the activity that was most
      *                      recently used to share.
      * @param isIncognito Whether currentTab is incognito.
      */
     public void onShareMenuItemSelected(final boolean shareDirectly, boolean isIncognito) {
         final Tab currentTab = getActivityTab();
         if (currentTab == null) return;
 
         final Activity mainActivity = this;
         ContentBitmapCallback callback = new ContentBitmapCallback() {
                     @Override

[fgorski, 2016/06/23 17:41:10]

nit: this indentation looks weir to me. Since it is defining a new class it
should probably be only 4 lines. (and that will make the rest of the code look
less weird.

[Vivian, 2016/06/27 16:56:08]

Done.

                     public void onFinishGetBitmap(Bitmap bitmap, int response) {
                         // Check whether this page is an offline page, and use its online URL if so.
                         String url = currentTab.getOfflinePageOriginalUrl();
                         RecordHistogram.recordBooleanHistogram(
                                 "OfflinePages.SharedPageWasOffline", url != null);
+                        boolean offlinePageSharing =
+                                (url != null && OfflinePageBridge.isPageSharingEnabled());
 
-                        // If there is no entry in the offline pages DB for this tab, use the tab's
-                        // URL directly.
-                        if (url == null) url = currentTab.getUrl();
+                        if (!offlinePageSharing) {
+                            // If there is no entry in the offline pages DB for this tab, use the
+                            // tab's

[fgorski, 2016/06/23 17:41:10]

nit: please remove NL from the end.

[Vivian, 2016/06/27 16:56:08]

Done.

+                            // URL directly.
+                            if (url == null) url = currentTab.getUrl();
 
-                        ShareHelper.share(
-                                shareDirectly, mainActivity, currentTab.getTitle(), url, bitmap);
-                        if (shareDirectly) {
-                            RecordUserAction.record("MobileMenuDirectShare");
+                            ShareHelper.share(shareDirectly, mainActivity, currentTab.getTitle(),
+                                    url, bitmap);
+                            if (shareDirectly) {
+                                RecordUserAction.record("MobileMenuDirectShare");
+                            } else {
+                                RecordUserAction.record("MobileMenuShare");
+                            }
                         } else {
-                            RecordUserAction.record("MobileMenuShare");
+                            // This is for experienmental feature Offline Page Sharing

[fgorski, 2016/06/23 17:41:11]

nit: End sentences with a period, please.

[Vivian, 2016/06/27 16:56:08]

Done.

+                            // If this page is an offline page, and the share the offline page
+                            // instead of url

[fgorski, 2016/06/23 17:41:11]

ditto Re: period.

[Vivian, 2016/06/27 16:56:08]

Done.

+                            String offlineUrl = currentTab.getUrl();

[fgorski, 2016/06/23 17:41:11]

how do you know the URL is offline here?

[Vivian, 2016/06/27 16:56:08]

It is checked in this line:

boolean offlinePageSharing =
                        (url != null &&
OfflinePageBridge.isPageSharingEnabled());

So my understanding is that if it goes to the else statement, then it must be an
offline page, and the tab.getUrl() should return the offline url. Let me know if
there's anything wrong with my understanding.

+                            OfflinePageBridge offlinePageBridge =
+                                    OfflinePageBridge.getForProfile(currentTab.getProfile());
+
+                            offlinePageBridge.getPageByOfflineUrl(

[fgorski, 2016/06/23 17:41:10]

Perhaps this whole code could be moved outside of ChromeActivity, e.g. to
OfflinePageUtils or OfflinePageBridge and tested there. Let's try to avoid
putting logic in here.

[Vivian, 2016/06/27 16:56:08]

Done. This part is moved to OfflinePageUtils.

+                                    offlineUrl, new Callback<OfflinePageItem>() {
+                                        @Override
+                                        public void onResult(OfflinePageItem item) {
+                                            if (item != null) {
+                                                String offlineFilePath = item.getFilePath();
+                                                Context mContext = getApplicationContext();
+                                                ShareHelper.shareOfflinePage(shareDirectly,
+                                                        mainActivity, currentTab.getTitle(),
+                                                        offlineFilePath, mContext);
+                                            }
+                                        }
+                                    });
                         }
                     }
                 };
         if (isIncognito || currentTab.getWebContents() == null) {
             callback.onFinishGetBitmap(null, ReadbackResponse.SURFACE_UNAVAILABLE);
         } else {
             currentTab.getWebContents().getContentBitmapAsync(
                     Bitmap.Config.ARGB_8888, 1.f, EMPTY_RECT, callback);
         }
     }
@@ skipping 753 matching lines @@
                 "Android.MultiWindowMode.IsTabletScreenWidthBelow600",
                 mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP);
 
         if (mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP) {
             RecordHistogram.recordLinearCountHistogram(
                     "Android.MultiWindowMode.TabletScreenWidth", mScreenWidthDp, 1,
                     DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP, 50);
         }
     }
 }