chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc - Issue 2081153002: No dbus::FileDescriptor in DebugDaemonClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

Issue 2081153002: No dbus::FileDescriptor in DebugDaemonClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/system_logs/debug_log_writer.cc ('K') | « chrome/browser/chromeos/system_logs/debug_log_writer.cc ('k') | chrome/browser/metrics/perf/perf_output.h » ('j') | chrome/browser/metrics/perf/perf_output.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

diff --git a/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc b/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

index 1cb54030adea11edc09ba69867213c59b5cac761..afeccec35118608da5d91a8a059c75748f0a205f 100644

--- a/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

+++ b/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

@@ -32,11 +32,10 @@ class TestDebugDaemonClient : public chromeos::FakeDebugDaemonClient {

~TestDebugDaemonClient() override {}

void DumpDebugLogs(bool is_compressed,

- base::File file,

- scoped_refptr<base::TaskRunner> task_runner,

+ int file_descriptor,

const GetDebugLogsCallback& callback) override {

- base::File* file_param = new base::File(std::move(file));

- task_runner->PostTaskAndReply(

+ base::File* file_param = new base::File(dup(file_descriptor));

+ content::BrowserThread::PostBlockingPoolTaskAndReply(

FROM_HERE,

base::Bind(

&GenerateTestLogDumpFile, test_file_, base::Owned(file_param)),