Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: dbus/message.h

Issue 2081153002: No dbus::FileDescriptor in DebugDaemonClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/pipe_reader.cc ('k') | dbus/message.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/message.h
diff --git a/dbus/message.h b/dbus/message.h
index 0aa010ccde0b7414a03392a64465a3e1cb298b77..272a740e4430b9d4701644b7643f6c8b7063c3ed 100644
--- a/dbus/message.h
+++ b/dbus/message.h
@@ -13,6 +13,7 @@
#include <string>
#include <vector>
+#include "base/files/scoped_file.h"
#include "base/macros.h"
#include "dbus/dbus_export.h"
#include "dbus/file_descriptor.h"
@@ -285,6 +286,13 @@ class CHROME_DBUS_EXPORT MessageWriter {
void AppendDouble(double value);
void AppendString(const std::string& value);
void AppendObjectPath(const ObjectPath& value);
+
+ // Appends a file descriptor to the message.
+ // The FD will be duplicated so you still have to close the original FD.
+ void AppendFileDescriptor(int value);
+
+ // DEPRECATED: Use the method with the same name above instead.
+ // TODO(hashimoto): Remove this. crbug.com/621841
void AppendFileDescriptor(const FileDescriptor& value);
// Opens an array. The array contents can be added to the array with
@@ -398,6 +406,10 @@ class CHROME_DBUS_EXPORT MessageReader {
bool PopDouble(double* value);
bool PopString(std::string* value);
bool PopObjectPath(ObjectPath* value);
+ bool PopFileDescriptor(base::ScopedFD* value);
+
+ // DEPRECATED: Use the method with the same name above.
+ // TODO(hashimoto): Remove this. crbug.com/621841
bool PopFileDescriptor(FileDescriptor* value);
// Sets up the given message reader to read an array at the current
« no previous file with comments | « chromeos/dbus/pipe_reader.cc ('k') | dbus/message.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698