Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: chrome/browser/ui/website_settings/mock_permission_bubble_factory.h

Issue 2081103002: Rename PermissionBubbleManager to PermissionRequestManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/mock_permission_bubble_factory.h
diff --git a/chrome/browser/ui/website_settings/mock_permission_bubble_factory.h b/chrome/browser/ui/website_settings/mock_permission_bubble_factory.h
index 471039f43c48460603b0bc06a99ed218664b8ca3..1c95f3f9289beea933ecec06c8abd136dc022072 100644
--- a/chrome/browser/ui/website_settings/mock_permission_bubble_factory.h
+++ b/chrome/browser/ui/website_settings/mock_permission_bubble_factory.h
@@ -8,8 +8,7 @@
#include <memory>
#include <vector>
-#include "base/callback.h"
-#include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
+#include "chrome/browser/permissions/permission_request_manager.h"
class Browser;
class PermissionBubbleView;
@@ -19,10 +18,10 @@ class MockPermissionBubbleView;
// test the bubble manager logic. Should not be used for anything that requires
// actual UI.
// See example usage in
-// chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
+// chrome/browser/ui/website_settings/permission_request_manager_unittest.cc
Lei Zhang 2016/07/13 02:04:24 Ah ha! A mistake! I finally feel useful. chrome/b
tsergeant 2016/07/13 04:20:53 Ah, nice pickup. Done.
class MockPermissionBubbleFactory {
public:
- explicit MockPermissionBubbleFactory(PermissionBubbleManager* manager);
+ explicit MockPermissionBubbleFactory(PermissionRequestManager* manager);
~MockPermissionBubbleFactory();
// Create method called by the PBM to show a bubble.
@@ -34,7 +33,7 @@ class MockPermissionBubbleFactory {
void DocumentOnLoadCompletedInMainFrame();
- void set_response_type(PermissionBubbleManager::AutoResponseType type) {
+ void set_response_type(PermissionRequestManager::AutoResponseType type) {
response_type_ = type;
}
@@ -65,12 +64,12 @@ class MockPermissionBubbleFactory {
int requests_count_;
int total_requests_count_;
std::vector<MockPermissionBubbleView*> views_;
- PermissionBubbleManager::AutoResponseType response_type_;
+ PermissionRequestManager::AutoResponseType response_type_;
base::Closure show_bubble_quit_closure_;
// The bubble manager that will be associated with this factory.
- PermissionBubbleManager* manager_;
+ PermissionRequestManager* manager_;
DISALLOW_COPY_AND_ASSIGN(MockPermissionBubbleFactory);
};

Powered by Google App Engine
This is Rietveld 408576698