[repaint-after-layout] Only repaint SVG root element when needed.

[repaint-after-layout] Only repaint SVG root element when needed.

With Repaint-After-Layout we would repaint the SVG Root element a lot more
then needed. This ports the check for when to repaint the SVG Root element
into the LayoutRectRecorder to better match what the LayoutRepainting was doing
originally.

BUG=320139
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169886

[dsinclair, 2014-03-21 12:25:09]

PTAL.

[Julien - ping for review, 2014-03-21 18:01:39]

lgtm. Adding @pdr in case he has more comments.

[esprehn, 2014-03-21 18:17:28]

https://codereview.chromium.org/208103002/diff/1/Source/core/rendering/svg/Re...
File Source/core/rendering/svg/RenderSVGRoot.cpp (right):

https://codereview.chromium.org/208103002/diff/1/Source/core/rendering/svg/Re...
Source/core/rendering/svg/RenderSVGRoot.cpp:202: LayoutRectRecorder
recorder(*this, !(checkForRepaint() && needsLayout));
Can you propagate the ! through the statement? It's much easier to read that
way.

!checkForRepaint() || !needsLayout()

[dsinclair, 2014-03-24 14:46:28]

https://codereview.chromium.org/208103002/diff/1/Source/core/rendering/svg/Re...
File Source/core/rendering/svg/RenderSVGRoot.cpp (right):

https://codereview.chromium.org/208103002/diff/1/Source/core/rendering/svg/Re...
Source/core/rendering/svg/RenderSVGRoot.cpp:202: LayoutRectRecorder
recorder(*this, !(checkForRepaint() && needsLayout));
On 2014/03/21 18:17:29, esprehn wrote:
> Can you propagate the ! through the statement? It's much easier to read that
> way.
> 
> !checkForRepaint() || !needsLayout()

The flag was badly named, so I inverted the meaning and made this just
checkForRepaint() && needsLayout()

[dsinclair, 2014-03-24 14:47:12]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2014-03-24 14:47:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dsinclair@chromium.org/208103002/20001

[commit-bot: I haz the power, 2014-03-24 14:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 14:48:54]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[dsinclair, 2014-03-24 14:50:37]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2014-03-24 14:50:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dsinclair@chromium.org/208103002/20001

[commit-bot: I haz the power, 2014-03-24 14:53:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 14:53:11]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[dsinclair, 2014-03-24 17:36:03]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2014-03-24 17:36:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dsinclair@chromium.org/208103002/20001

[commit-bot: I haz the power, 2014-03-24 18:40:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 18:40:19]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[dsinclair, 2014-03-24 18:51:48]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2014-03-24 18:51:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dsinclair@chromium.org/208103002/20001

[commit-bot: I haz the power, 2014-03-24 20:00:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 20:00:07]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[Julien - ping for review, 2014-03-24 21:56:18]

The CQ bit was checked by jchaffraix@chromium.org

[commit-bot: I haz the power, 2014-03-24 21:56:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dsinclair@chromium.org/208103002/20001

[commit-bot: I haz the power, 2014-03-24 23:50:52]

Change committed as 169886