third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h - Issue 2081013002: Re-enable DrMemory test for ICOImageDecoderTests.parseAndDecodeByteByByte.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h

Issue 2081013002: Re-enable DrMemory test for ICOImageDecoderTests.parseAndDecodeByteByByte. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp » ('j') | third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h

diff --git a/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h b/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h

index 0f875ffe6328a0940408ba4756d2c8053ba522f9..6c2482bff5987623cbdaf9d8d01931fefd4be415 100644

--- a/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h

+++ b/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h

@@ -84,7 +84,7 @@ private:

static bool compareEntries(const IconDirectoryEntry& a, const IconDirectoryEntry& b);

// ImageDecoder:

- virtual void decodeSize() { decode(0, true); }

+ void decodeSize() override { decode(0, true); }

size_t decodeFrameCount() override;

void decode(size_t index) override { decode(index, false); }