Added API for Bevel NormalSource.

src/core/SkLightingShader.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkBitmapProcShader.h"
 #include "SkBitmapProcState.h"
 #include "SkColor.h"
@@ skipping 473 matching lines @@
 
     return new (storage) LightingShaderContext(*this, rec, diffuseContext, normalProvider,
                                                heapAllocated);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 
 sk_sp<SkShader> SkLightingShader::Make(sk_sp<SkShader> diffuseShader,
                                        sk_sp<SkNormalSource> normalSource,
                                        sk_sp<SkLights> lights) {
-    if (!diffuseShader || !normalSource) {
+    if (!diffuseShader) {
         // TODO: Use paint's color in absence of a diffuseShader
-        // TODO: Use a default implementation of normalSource instead
         return nullptr;
     }

[robertphillips, 2016/07/11 19:13:21]

Hmmm, don't we just want the flat guy?

[dvonbeck, 2016/07/13 14:23:37]

This was before i wrote the flat guy. Now that I uploaded the rebase the flat
guy is used here.

[robertphillips, 2016/07/13 14:40:22]

This doesn't look like the flat guy. 

[dvonbeck, 2016/07/13 16:09:16]

Patch 5 no longer has modifications to lighting shader. Once this CL is landed
(after the nullptr CL lands) it will not modify SkLightingShader.cpp, so the
Make function will continue using the flat guy.

-
+    if (!normalSource) {
+        normalSource = SkNormalSource::MakeBevel(SkNormalSource::BevelType::kLinear, 0, 0);
+    }
     return sk_make_sp<SkLightingShaderImpl>(std::move(diffuseShader), std::move(normalSource),
                                             std::move(lights));
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 
 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_START(SkLightingShader)
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkLightingShaderImpl)
 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_END
 
 ///////////////////////////////////////////////////////////////////////////////