Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2080963002: Fix inspector layout tests to deal send tab via event sender. (Closed)

Created:
4 years, 6 months ago by dtapuska
Modified:
4 years, 6 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, caseq+blink_chromium.org, mlamouri+watch-test-runner_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, jochen+watch_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix inspector layout tests to deal send tab via event sender. Since the default action won't be executed inject the tab key down via the event sender. BUG=520519 Committed: https://crrev.com/8f3b1e5fecb46a0653ddbdc1009afcd528bc24c3 Cr-Commit-Position: refs/heads/master@{#401011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M components/test_runner/event_sender.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/edit-trimmed-attribute-value.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dtapuska
Please review.
4 years, 6 months ago (2016-06-20 21:40:07 UTC) #2
Rick Byers
LGTM
4 years, 6 months ago (2016-06-21 15:18:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080963002/1
4 years, 6 months ago (2016-06-21 15:20:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 16:34:25 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 16:42:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f3b1e5fecb46a0653ddbdc1009afcd528bc24c3
Cr-Commit-Position: refs/heads/master@{#401011}

Powered by Google App Engine
This is Rietveld 408576698