Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2080923002: Remove calls to MessageLoop::current() in mojo. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::current() in mojo. Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop. These changes were generated manually. BUG=616447 R=ben@chromium.org Committed: https://crrev.com/b9d291f3d13f4691eb24ae93b4a23d091125e972 Cr-Commit-Position: refs/heads/master@{#401028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/message_pump/handle_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-21 17:20:11 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 6 months ago (2016-06-21 17:26:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080923002/1
4 years, 6 months ago (2016-06-21 17:30:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 17:37:38 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 17:49:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9d291f3d13f4691eb24ae93b4a23d091125e972
Cr-Commit-Position: refs/heads/master@{#401028}

Powered by Google App Engine
This is Rietveld 408576698