Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2080893002: Close all sources command (Closed)

Created:
4 years, 6 months ago by einbinder
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Close all sources command Add close all to command search for the sources pane. BUG=619913 Committed: https://crrev.com/8d4cdf7a874c7a4e44615f03a9e70d5e7810b99f Cr-Commit-Position: refs/heads/master@{#402307}

Patch Set 1 #

Total comments: 12

Patch Set 2 : change to closeAllFiles #

Total comments: 8

Patch Set 3 : Remove closeAllFiles from SourcesView #

Patch Set 4 : Forgot a semi colon #

Patch Set 5 : Remove alert hi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/module.json View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
einbinder
4 years, 6 months ago (2016-06-20 18:20:18 UTC) #3
dgozman
https://codereview.chromium.org/2080893002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js File third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js (right): https://codereview.chromium.org/2080893002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js#newcode197 third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:197: closeAllTabs: function(){ style: { on next line https://codereview.chromium.org/2080893002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js#newcode811 third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:811: ...
4 years, 6 months ago (2016-06-20 18:32:36 UTC) #4
einbinder
ptal https://codereview.chromium.org/2080893002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js File third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js (right): https://codereview.chromium.org/2080893002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js#newcode197 third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:197: closeAllTabs: function(){ On 2016/06/20 18:32:36, dgozman wrote: > ...
4 years, 6 months ago (2016-06-20 19:28:25 UTC) #5
dgozman
https://codereview.chromium.org/2080893002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js File third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js (right): https://codereview.chromium.org/2080893002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js#newcode799 third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:799: WebInspector.SourcesView.CloseAllActionDelegate = function(){ style: { on the next line ...
4 years, 6 months ago (2016-06-20 21:00:23 UTC) #6
einbinder
ptal https://codereview.chromium.org/2080893002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js File third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js (right): https://codereview.chromium.org/2080893002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js#newcode799 third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:799: WebInspector.SourcesView.CloseAllActionDelegate = function(){ On 2016/06/20 21:00:23, dgozman wrote: ...
4 years, 6 months ago (2016-06-20 21:16:43 UTC) #7
dgozman
lgtm
4 years, 6 months ago (2016-06-20 21:21:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2080893002/80001
4 years, 5 months ago (2016-06-27 18:54:10 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-06-27 21:59:59 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 22:03:18 UTC) #14
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/8d4cdf7a874c7a4e44615f03a9e70d5e7810b99f
Cr-Commit-Position: refs/heads/master@{#402307}

Powered by Google App Engine
This is Rietveld 408576698