Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2080873003: X87: [turbofan] Add comments to CodeAssembler. (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Add comments to CodeAssembler. port 40b5c1d41f7da58411d5538f26cc736d2f40abe0(r36842) original commit message: BUG= Committed: https://crrev.com/2c70addcf2fe0bdb14fbb53cea79cb96ed81b6e7 Cr-Commit-Position: refs/heads/master@{#37124}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-21 02:09:18 UTC) #2
Weiliang
lgtm
4 years, 6 months ago (2016-06-21 03:00:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080873003/1
4 years, 6 months ago (2016-06-21 05:31:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 05:56:12 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 05:56:26 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2c70addcf2fe0bdb14fbb53cea79cb96ed81b6e7
Cr-Commit-Position: refs/heads/master@{#37124}

Powered by Google App Engine
This is Rietveld 408576698