Oilpan: move ApplicationCache to the oilpan heap.

Oilpan: move ApplicationCache to the oilpan heap.

Make this EventTarget-derived object a garbage collected object.

R=haraken@chromium.org
BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169744

[sof, 2014-03-21 14:33:08]

Please take a look.

[Last one of these.. time to transition DOMWindow itself next.]

[haraken, 2014-03-21 14:41:20]

There remains several RefPtr<ApplicationCache>s in the code base. Could you
replace them with RefPtrWillRawPtr<ApplicationCache> in this CL?
https://code.google.com/p/chromium/codesearch#search/&q=refptr%3CApplicationC...

https://codereview.chromium.org/208083003/diff/20001/Source/core/loader/appca...
File Source/core/loader/appcache/ApplicationCache.h (right):

https://codereview.chromium.org/208083003/diff/20001/Source/core/loader/appca...
Source/core/loader/appcache/ApplicationCache.h:52: virtual ~ApplicationCache() {
ASSERT(!m_frame); }

Just to confirm: DOMWindowProperty has LocalFrame* and DOMWindow*, but these raw
pointers are no problem because they are cleared in
DOMWindowProperty::willDetachGlobalObjectFromFrame(), right?

(These raw pointers would be no problem because ApplicationCache is still
"RefCounted"GarbageCollected. I want to make sure that they are no problem even
if we change it to GarbageCollected.)

[sof, 2014-03-21 14:51:47]

On 2014/03/21 14:41:20, haraken wrote:
> There remains several RefPtr<ApplicationCache>s in the code base. Could you
> replace them with RefPtrWillRawPtr<ApplicationCache> in this CL?
>
https://code.google.com/p/chromium/codesearch#search/&q=refptr%253CApplicatio...
> 

I've taken care of all of them; the ones showing there are gen/ occurrences
(which are now gone.)

>
https://codereview.chromium.org/208083003/diff/20001/Source/core/loader/appca...
> File Source/core/loader/appcache/ApplicationCache.h (right):
> 
>
https://codereview.chromium.org/208083003/diff/20001/Source/core/loader/appca...
> Source/core/loader/appcache/ApplicationCache.h:52: virtual ~ApplicationCache()
{
> ASSERT(!m_frame); }
> 
> Just to confirm: DOMWindowProperty has LocalFrame* and DOMWindow*, but these
raw
> pointers are no problem because they are cleared in
> DOMWindowProperty::willDetachGlobalObjectFromFrame(), right?
> 

Yes, they are cleared there, so if there are any code paths that doesn't
explicitly detach first, the assert will trigger.

[haraken, 2014-03-21 14:53:28]

On 2014/03/21 14:51:47, sof wrote:
> On 2014/03/21 14:41:20, haraken wrote:
> > There remains several RefPtr<ApplicationCache>s in the code base. Could you
> > replace them with RefPtrWillRawPtr<ApplicationCache> in this CL?
> >
>
https://code.google.com/p/chromium/codesearch#search/&q=refptr%25253CApplicat...
> > 
> 
> I've taken care of all of them; the ones showing there are gen/ occurrences
> (which are now gone.)

Thanks for the clarification. LGTM.

[sof, 2014-03-21 15:05:52]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-03-21 15:06:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/208083003/20001

[commit-bot: I haz the power, 2014-03-21 15:37:44]

Change committed as 169744