Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2080813004: Move platform/MemoryPurgeController -> core/dom/MemoryCoordinator (Closed)

Created:
4 years, 6 months ago by bashi
Modified:
4 years, 6 months ago
Reviewers:
haraken, tasak
CC:
chromium-reviews, blink-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move platform/MemoryPurgeController -> core/dom/MemoryCoordinator Reason for renaming: We are going to replace MemoryPressureListener with memory coordinator[1]. The role of this class will not be limited to purge caches but also handle other memory events like throttling. Reason for moving platform to core: MemoryCoordinator depends (and will depend) on things which live in core. For example, it needs to ask MemoryCache to prune caches. It would also ask StyleEngine to clear textToSheet and seetToText caches in the future. Putting MemoryCoordinator in platform is a source of unwanted indirections. Also, this CL removes MemoryPUrgeClient. It doesn't make sense to create an instance of MemoryCoordinator per-page because the current implementation doesn't do any per-page specific task. If we need to do a per-page specific task in the future we can iterate over ordinaryPages() in MemoryCoordinator to ask pages to execute the task. BUG=617492 [1] https://docs.google.com/document/d/1dkUXXmpJk7xBUeQM-olBpTHJ2MXamDgY_kjNrl9JXMs Committed: https://crrev.com/e9f7f82984084ef170e580cf6550154fbb585c6d Cr-Commit-Position: refs/heads/master@{#400911}

Patch Set 1 #

Patch Set 2 : move to dom/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -162 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/MemoryCoordinator.h View 1 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/MemoryCoordinator.cpp View 1 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 5 chunks +1 line, -9 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 6 chunks +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/platform/MemoryPurgeController.h View 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/WebKit/Source/platform/MemoryPurgeController.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebMemoryCoordinator.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080813004/1
4 years, 6 months ago (2016-06-21 03:13:07 UTC) #2
bashi
PTAL
4 years, 6 months ago (2016-06-21 03:48:13 UTC) #4
haraken
Oilpan (in platform/) can be a client of the MemoryCoordinator. How will it work? Are ...
4 years, 6 months ago (2016-06-21 04:02:37 UTC) #5
bashi
On 2016/06/21 04:02:37, haraken wrote: > Oilpan (in platform/) can be a client of the ...
4 years, 6 months ago (2016-06-21 04:12:36 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-21 04:29:03 UTC) #8
haraken
LGTM How many files are you going to add to core/memory/? If the directory is ...
4 years, 6 months ago (2016-06-21 05:13:11 UTC) #9
bashi
On 2016/06/21 05:13:11, haraken wrote: > LGTM > > How many files are you going ...
4 years, 6 months ago (2016-06-21 05:39:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080813004/20001
4 years, 6 months ago (2016-06-21 05:40:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080813004/20001
4 years, 6 months ago (2016-06-21 05:42:37 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 06:57:32 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 07:03:58 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9f7f82984084ef170e580cf6550154fbb585c6d
Cr-Commit-Position: refs/heads/master@{#400911}

Powered by Google App Engine
This is Rietveld 408576698