Issue 20808004: MIPS: Add Smi support to Shl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20808004: MIPS: Add Smi support to Shl (Closed)

Created:
7 years, 5 months ago by palfia

Modified:
7 years, 4 months ago

Reviewers:
kisg, Paul Lind, kilvadyb, danno, Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Add Smi support to Shl Port r15910 (8e65c434) BUG= Committed: https://code.google.com/p/v8/source/detail?r=15913

Patch Set 2 : Fixed nit. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -9 lines)			Patch
	M	src/mips/lithium-codegen-mips.cc	View		2 chunks	+9 lines, -1 line	0 comments	Download
	M	src/mips/lithium-mips.cc	View	1	2 chunks	+18 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM, but please fix the comment nit. https://codereview.chromium.org/20808004/diff/1/src/mips/lithium-mips.cc File src/mips/lithium-mips.cc (right): https://codereview.chromium.org/20808004/diff/1/src/mips/lithium-mips.cc#newcode753 src/mips/lithium-mips.cc:753: // Shift ...

7 years, 5 months ago (2013-07-26 22:58:58 UTC) #2

palfia

Fixed nit, thanks! https://codereview.chromium.org/20808004/diff/1/src/mips/lithium-mips.cc File src/mips/lithium-mips.cc (right): https://codereview.chromium.org/20808004/diff/1/src/mips/lithium-mips.cc#newcode753 src/mips/lithium-mips.cc:753: // Shift operations can only deoptimize ...

7 years, 4 months ago (2013-07-26 23:55:02 UTC) #3

Message was sent while issue was closed.

Committed manually as r15913 (presubmit successful).

Expand Messages | Collapse Messages

Issue 20808004: MIPS: Add Smi support to Shl (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixed nit. #

Messages