Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: lib/error.dart

Issue 2080783002: Reduce usage of buildUnsupported. (Closed) Base URL: git@github.com:dart-lang/rasta.git@status
Patch Set: Remove normally. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/kernel_visitor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/error.dart
diff --git a/lib/error.dart b/lib/error.dart
index caf691df4d5d748965b33344d887f7f2ad20fe2e..27d4c3146525aad8d327d3b67398ccf2cb5d5e7b 100644
--- a/lib/error.dart
+++ b/lib/error.dart
@@ -21,6 +21,7 @@ import "package:compiler/src/dart_types.dart" show
DartType;
import "package:compiler/src/tree/tree.dart" show
+ Expression,
NewExpression,
Node,
NodeList,
@@ -34,9 +35,11 @@ import "package:compiler/src/universe/selector.dart" show
import 'package:kernel/ast.dart' as ir;
abstract class RastaError {
- ir.Throw handleError(Node node);
+ // TODO(ahe): Get rid of this method, each error should be handled according
+ // to the semantics required by the Dart Language Specification.
+ ir.Expression handleError(Expression node);
- ir.Throw errorInvalidBinary(
+ ir.Expression errorInvalidBinary(
Send node,
ErroneousElement error,
BinaryOperator operator,
@@ -45,7 +48,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidCompound(
+ ir.Expression errorInvalidCompound(
Send node,
ErroneousElement error,
AssignmentOperator operator,
@@ -54,7 +57,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidCompoundIndexSet(
+ ir.Expression errorInvalidCompoundIndexSet(
Send node,
ErroneousElement error,
Node index,
@@ -64,7 +67,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidEquals(
+ ir.Expression errorInvalidEquals(
Send node,
ErroneousElement error,
Node right,
@@ -72,14 +75,14 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidGet(
+ ir.Expression errorInvalidGet(
Send node,
ErroneousElement error,
_) {
return handleError(node);
}
- ir.Throw errorInvalidIndex(
+ ir.Expression errorInvalidIndex(
Send node,
ErroneousElement error,
Node index,
@@ -87,7 +90,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidIndexPostfix(
+ ir.Expression errorInvalidIndexPostfix(
Send node,
ErroneousElement error,
Node index,
@@ -96,7 +99,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidIndexPrefix(
+ ir.Expression errorInvalidIndexPrefix(
Send node,
ErroneousElement error,
Node index,
@@ -105,7 +108,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidIndexSet(
+ ir.Expression errorInvalidIndexSet(
Send node,
ErroneousElement error,
Node index,
@@ -114,7 +117,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidInvoke(
+ ir.Expression errorInvalidInvoke(
Send node,
ErroneousElement error,
NodeList arguments,
@@ -123,7 +126,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidNotEquals(
+ ir.Expression errorInvalidNotEquals(
Send node,
ErroneousElement error,
Node right,
@@ -131,7 +134,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidPostfix(
+ ir.Expression errorInvalidPostfix(
Send node,
ErroneousElement error,
IncDecOperator operator,
@@ -139,7 +142,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidPrefix(
+ ir.Expression errorInvalidPrefix(
Send node,
ErroneousElement error,
IncDecOperator operator,
@@ -147,7 +150,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidSet(
+ ir.Expression errorInvalidSet(
Send node,
ErroneousElement error,
Node rhs,
@@ -155,7 +158,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidSetIfNull(
+ ir.Expression errorInvalidSetIfNull(
Send node,
ErroneousElement error,
Node rhs,
@@ -163,7 +166,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidUnary(
+ ir.Expression errorInvalidUnary(
Send node,
UnaryOperator operator,
ErroneousElement error,
@@ -171,7 +174,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorNonConstantConstructorInvoke(
+ ir.Expression errorNonConstantConstructorInvoke(
NewExpression node,
Element element,
DartType type,
@@ -181,7 +184,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorUndefinedBinaryExpression(
+ ir.Expression errorUndefinedBinaryExpression(
Send node,
Node left,
Operator operator,
@@ -190,7 +193,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorUndefinedUnaryExpression(
+ ir.Expression errorUndefinedUnaryExpression(
Send node,
Operator operator,
Node expression,
@@ -198,7 +201,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorUnresolvedFieldInitializer(
+ ir.Expression errorUnresolvedFieldInitializer(
SendSet node,
Element element,
Node initializer,
@@ -206,7 +209,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorUnresolvedSuperConstructorInvoke(
+ ir.Expression errorUnresolvedSuperConstructorInvoke(
Send node,
Element element,
NodeList arguments,
@@ -215,7 +218,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorUnresolvedThisConstructorInvoke(
+ ir.Expression errorUnresolvedThisConstructorInvoke(
Send node,
Element element,
NodeList arguments,
@@ -224,7 +227,7 @@ abstract class RastaError {
return handleError(node);
}
- ir.Throw errorInvalidIndexSetIfNull(
+ ir.Expression errorInvalidIndexSetIfNull(
SendSet node, ErroneousElement error, Node index, Node rhs, _) {
return handleError(node);
}
« no previous file with comments | « no previous file | lib/kernel_visitor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698