Issue 2080753002: crypto: Add BoringSSL accelerated version of SHA-1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2080753002: crypto: Add BoringSSL accelerated version of SHA-1

Created:
4 years, 6 months ago by robert.bradford

Modified:
4 years, 6 months ago

Reviewers:
agl, davidben, Ryan Sleevi

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

crypto: Add BoringSSL accelerated version of SHA-1 This can be used by code that can depend on the crypto/ directory and give a SHA-1 implementation with much improved performance. TEST=crypto_unittests:SHA1Test BUG=621530

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -7 lines)			Patch
M	crypto/BUILD.gn	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	crypto/crypto.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	crypto/crypto.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	crypto/secure_hash.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	crypto/secure_hash.cc	View	2 chunks	+30 lines, -0 lines	0 comments	Download
A	crypto/sha1.h	View	1 chunk	+34 lines, -0 lines	0 comments	Download
A +	crypto/sha1.cc	View	2 chunks	+7 lines, -7 lines	0 comments	Download
A	crypto/sha1_unittest.cc	View	1 chunk	+48 lines, -0 lines	0 comments	Download

Dependent Patchsets:

Issue 2081553003 Patch 1

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

robert.bradford

agl@ please could you take a look at this CL - there are some numbers ...

4 years, 6 months ago (2016-06-20 15:24:03 UTC) #2

agl

4 years, 6 months ago (2016-06-20 16:39:11 UTC) #4

I presume that this CL is planned to be followed by a number of others that move
users of SHA1 from base/ to this version in crypto/?

Are there any numbers to suggest that any particular users of SHA1 from base/
are hashing enough data to notice?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages