Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 208073003: IA32: Rename MacroAssembler::Set() and MacroAssembler::SafeSet() to Move() and SafeMove(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 __ Assert(zero, kUnableToEncodeValueAsSmi); 131 __ Assert(zero, kUnableToEncodeValueAsSmi);
132 } 132 }
133 __ SmiTag(reg); 133 __ SmiTag(reg);
134 __ push(reg); 134 __ push(reg);
135 } 135 }
136 } 136 }
137 137
138 #ifdef DEBUG 138 #ifdef DEBUG
139 __ RecordComment("// Calling from debug break to runtime - come in - over"); 139 __ RecordComment("// Calling from debug break to runtime - come in - over");
140 #endif 140 #endif
141 __ Set(eax, Immediate(0)); // No arguments. 141 __ Move(eax, Immediate(0)); // No arguments.
142 __ mov(ebx, Immediate(ExternalReference::debug_break(masm->isolate()))); 142 __ mov(ebx, Immediate(ExternalReference::debug_break(masm->isolate())));
143 143
144 CEntryStub ceb(1); 144 CEntryStub ceb(1);
145 __ CallStub(&ceb); 145 __ CallStub(&ceb);
146 146
147 // Automatically find register that could be used after register restore. 147 // Automatically find register that could be used after register restore.
148 // We need one register for padding skip instructions. 148 // We need one register for padding skip instructions.
149 Register unused_reg = { -1 }; 149 Register unused_reg = { -1 };
150 150
151 // Restore the register values containing object pointers from the 151 // Restore the register values containing object pointers from the
152 // expression stack. 152 // expression stack.
153 for (int i = kNumJSCallerSaved; --i >= 0;) { 153 for (int i = kNumJSCallerSaved; --i >= 0;) {
154 int r = JSCallerSavedCode(i); 154 int r = JSCallerSavedCode(i);
155 Register reg = { r }; 155 Register reg = { r };
156 if (FLAG_debug_code) { 156 if (FLAG_debug_code) {
157 __ Set(reg, Immediate(kDebugZapValue)); 157 __ Move(reg, Immediate(kDebugZapValue));
158 } 158 }
159 bool taken = reg.code() == esi.code(); 159 bool taken = reg.code() == esi.code();
160 if ((object_regs & (1 << r)) != 0) { 160 if ((object_regs & (1 << r)) != 0) {
161 __ pop(reg); 161 __ pop(reg);
162 taken = true; 162 taken = true;
163 } 163 }
164 if ((non_object_regs & (1 << r)) != 0) { 164 if ((non_object_regs & (1 << r)) != 0) {
165 __ pop(reg); 165 __ pop(reg);
166 __ SmiUntag(reg); 166 __ SmiUntag(reg);
167 taken = true; 167 taken = true;
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 367
368 const bool Debug::kFrameDropperSupported = true; 368 const bool Debug::kFrameDropperSupported = true;
369 369
370 #undef __ 370 #undef __
371 371
372 #endif // ENABLE_DEBUGGER_SUPPORT 372 #endif // ENABLE_DEBUGGER_SUPPORT
373 373
374 } } // namespace v8::internal 374 } } // namespace v8::internal
375 375
376 #endif // V8_TARGET_ARCH_IA32 376 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698