[Chromoting] Use device::PowerSaveBlocker to block screen saver

remoting/host/basic_desktop_environment.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/basic_desktop_environment.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/single_thread_task_runner.h"
@@ skipping 52 matching lines @@
 }
 
 void BasicDesktopEnvironment::SetCapabilities(const std::string& capabilities) {
 }
 
 std::unique_ptr<webrtc::DesktopCapturer>
 BasicDesktopEnvironment::CreateVideoCapturer() {
   DCHECK(caller_task_runner_->BelongsToCurrentThread());
 
   return base::WrapUnique(new DesktopCapturerProxy(video_capture_task_runner_,
+                                                   ui_task_runner_,
+                                                   caller_task_runner_,

[Hzj_jie, 2016/06/22 18:57:59]

We have not sent file_task_runner to BasicDesktopEnvironment, so I choose
network_task_runner (caller_task_runner_) instead. The IO blocking jobs are only
injected in PowerSaveBlocker's constructor and destructor, i.e.
DesktopCapturerProxy's constructor and destructor. Since there are no network
requests during that time, the impact would be small.

[Sergey Ulanov, 2016/06/22 19:05:37]

I don't think this is acceptable. We should never have any blocking tasks
running on network thread.

[Hzj_jie, 2016/06/24 19:14:29]

I think all the jobs in network thread are all IO jobs, thus type of
network_task_runner is TYPE_IO. But I also found a DisallowBlockingOpertions has
been applied to it, which looks weird. Can I assume only asynchronized jobs are
executing on a network_task_runner?

[Sergey Ulanov, 2016/06/27 18:20:24]

That's right, we only allow non-blocking IO on that thread.

                                                    *desktop_capture_options_));
 }
 
 BasicDesktopEnvironment::BasicDesktopEnvironment(
     scoped_refptr<base::SingleThreadTaskRunner> caller_task_runner,
     scoped_refptr<base::SingleThreadTaskRunner> video_capture_task_runner,
     scoped_refptr<base::SingleThreadTaskRunner> input_task_runner,
     scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
     bool supports_touch_events)
     : caller_task_runner_(caller_task_runner),
@@ skipping 22 matching lines @@
 
 BasicDesktopEnvironmentFactory::~BasicDesktopEnvironmentFactory() {}
 
 bool BasicDesktopEnvironmentFactory::SupportsAudioCapture() const {
   DCHECK(caller_task_runner_->BelongsToCurrentThread());
 
   return AudioCapturer::IsSupported();
 }
 
 }  // namespace remoting