third_party/WebKit/Source/core/css/CSSMarkup.cpp - Issue 2080723003: CSS Variable #0000ee is read as #\30 000ee

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSMarkup.cpp

Issue 2080723003: CSS Variable #0000ee is read as #\30 000ee (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSMarkup.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSMarkup.cpp b/third_party/WebKit/Source/core/css/CSSMarkup.cpp

index 55987e9b4769192c450a6a8205e678c331406702..3b04a4dcbbeead693338d53925fb7cd45461b8e9 100644

--- a/third_party/WebKit/Source/core/css/CSSMarkup.cpp

+++ b/third_party/WebKit/Source/core/css/CSSMarkup.cpp

@@ -82,9 +82,11 @@ static void serializeCharacterAsCodePoint(UChar32 c, StringBuilder& appendTo)

appendTo.append(' ');

}

-void serializeIdentifier(const String& identifier, StringBuilder& appendTo)

+void serializeIdentifier(const String& identifier, StringBuilder& appendTo, bool skipStartChecks)

{

bool isFirst = true;

Timothy Loh 2016/06/23 21:37:32 could just write bool isFirst = !skipStartChecks;

ramya.v 2016/06/24 04:31:52 Done.

+ if (skipStartChecks)

+ isFirst = false;

bool isSecond = false;

bool isFirstCharHyphen = false;

unsigned index = 0;