CSS Variable #0000ee is read as #\30 000ee

CSS Variable #0000ee is read as #\30 000ee

Handled HashTokenTypes seperately.

BUG=617694
Committed: https://crrev.com/7b65d1f3c241e1e5fe2d06b8fc272dc86c1ff44f
Cr-Commit-Position: refs/heads/master@{#401828}

[ramya.v, 2016-06-22 09:15:07]

Description was changed from

==========
CSS Variable #0000ee is read as #\30 000ee

BUG=617694
==========

to

==========
CSS Variable #0000ee is read as #\30 000ee

Handled HashTokenTypes seperately.

BUG=617694
==========

[ramya.v, 2016-06-22 09:15:27]

ramya.v@samsung.com changed reviewers:
+ timloh@chromium.org

[ramya.v, 2016-06-22 09:15:28]

PTAL!

Thanks

[Timothy Loh, 2016-06-22 10:25:40]

On 2016/06/22 09:15:28, ramya.v wrote:
> PTAL!
> 
> Thanks

I think this doesn't work for a case like:

--foo: #1\.;

Maybe serializeIdentifier could take a boolean (skipStartChecks?), which when
true isFirst and isSecond both start as false.

[ramya.v, 2016-06-23 03:45:49]

Updated as per review comments. PTAL!

Thanks

[Timothy Loh, 2016-06-23 21:37:32]

lgtm, but please add a test for something like the css value #1\. should
serialize with the \.

https://codereview.chromium.org/2080723003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSMarkup.cpp (right):

https://codereview.chromium.org/2080723003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSMarkup.cpp:87: bool isFirst = true;
could just write bool isFirst = !skipStartChecks;

[ramya.v, 2016-06-24 04:31:52]

Updated test to include #1\. case.

https://codereview.chromium.org/2080723003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSMarkup.cpp (right):

https://codereview.chromium.org/2080723003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSMarkup.cpp:87: bool isFirst = true;
On 2016/06/23 21:37:32, Timothy Loh wrote:
> could just write bool isFirst = !skipStartChecks;

Done.

[ramya.v, 2016-06-24 04:33:26]

The CQ bit was checked by ramya.v@samsung.com

[ramya.v, 2016-06-24 04:33:27]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2080723003/#ps80001
(title: "Updated testcase")

[commit-bot: I haz the power, 2016-06-24 04:33:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2080723003/80001

[commit-bot: I haz the power, 2016-06-24 06:56:08]

Description was changed from

==========
CSS Variable #0000ee is read as #\30 000ee

Handled HashTokenTypes seperately.

BUG=617694
==========

to

==========
CSS Variable #0000ee is read as #\30 000ee

Handled HashTokenTypes seperately.

BUG=617694
==========

[commit-bot: I haz the power, 2016-06-24 06:56:09]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-24 06:58:17]

Description was changed from

==========
CSS Variable #0000ee is read as #\30 000ee

Handled HashTokenTypes seperately.

BUG=617694
==========

to

==========
CSS Variable #0000ee is read as #\30 000ee

Handled HashTokenTypes seperately.

BUG=617694

Committed: https://crrev.com/7b65d1f3c241e1e5fe2d06b8fc272dc86c1ff44f
Cr-Commit-Position: refs/heads/master@{#401828}
==========

[commit-bot: I haz the power, 2016-06-24 06:58:18]

Patchset 5 (id:??) landed as
https://crrev.com/7b65d1f3c241e1e5fe2d06b8fc272dc86c1ff44f
Cr-Commit-Position: refs/heads/master@{#401828}