Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2080703006: [turbofan] Some strength reduction on Smi/HeapObject checks. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Some strength reduction on Smi/HeapObject checks. Let the SimplifiedOperatorReducer perform some strength reduction for certain CheckTaggedSigned and CheckTaggedPointer inputs (reusing the existing logic for ObjectIsSmi). R=jarin@chromium.org BUG=v8:5141 Committed: https://crrev.com/c30b854aa32cf1b242523b565eb19f397f6cb55c Cr-Commit-Position: refs/heads/master@{#37167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -16 lines) Patch
M src/compiler/common-operator-reducer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 2 chunks +46 lines, -7 lines 0 comments Download
M src/globals.h View 1 chunk +20 lines, -0 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 2 chunks +58 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-22 07:03:12 UTC) #1
Benedikt Meurer
Hey Jaro, Here's some initial check optimization (essentially what worked for ObjectIsSmi already). Please take ...
4 years, 6 months ago (2016-06-22 07:03:52 UTC) #2
Jarin
lgtm
4 years, 6 months ago (2016-06-22 07:07:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080703006/1
4 years, 6 months ago (2016-06-22 07:48:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 07:50:42 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 07:52:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c30b854aa32cf1b242523b565eb19f397f6cb55c
Cr-Commit-Position: refs/heads/master@{#37167}

Powered by Google App Engine
This is Rietveld 408576698