Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2080703005: cc: Remove LayerTreeImpl::root_layer usage outside tests (Closed)

Created:
4 years, 6 months ago by jaydasika
Modified:
4 years, 6 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove LayerTreeImpl::root_layer usage outside tests BUG=602438 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4 Cr-Commit-Position: refs/heads/master@{#401276}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -84 lines) Patch
M cc/debug/debug_rect_history.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/debug/debug_rect_history.cc View 5 chunks +11 lines, -13 lines 0 comments Download
M cc/test/layer_tree_json_parser_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 12 chunks +21 lines, -31 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 16 chunks +27 lines, -19 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/trees/occlusion_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/property_tree.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/tree_synchronizer.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/tree_synchronizer.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jaydasika
PTAL
4 years, 6 months ago (2016-06-22 01:44:09 UTC) #5
Ian Vollick
On 2016/06/22 at 01:44:09, jaydasika wrote: > PTAL Overall, this lgtm, but if root_layer is ...
4 years, 6 months ago (2016-06-22 12:15:30 UTC) #6
jaydasika
On 2016/06/22 12:15:30, vollick wrote: > On 2016/06/22 at 01:44:09, jaydasika wrote: > > PTAL ...
4 years, 6 months ago (2016-06-22 13:33:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080703005/40001
4 years, 6 months ago (2016-06-22 13:54:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-22 14:33:08 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 14:35:22 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4
Cr-Commit-Position: refs/heads/master@{#401276}

Powered by Google App Engine
This is Rietveld 408576698