Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2080703003: [turbofan] MemoryOptimizer cannot deal with dead nodes in use lists. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] MemoryOptimizer cannot deal with dead nodes in use lists. We need to trim the graph before we execute the MemoryOptimizer, because that just walks the effect chain from Start to End and cannot deal with dead nodes in the use lists. R=jarin@chromium.org BUG=chromium:614292 Committed: https://crrev.com/5e0cd389bff2833c0b13179977b11ec216330bb3 Cr-Commit-Position: refs/heads/master@{#37133}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M src/compiler/pipeline.cc View 1 chunk +7 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-614292.js View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-21 07:56:53 UTC) #1
Benedikt Meurer
Hey Jaro, Moar trimming, yay! Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-06-21 07:57:25 UTC) #2
Jarin
lgtm :-/
4 years, 6 months ago (2016-06-21 09:01:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080703003/1
4 years, 6 months ago (2016-06-21 09:50:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 10:39:01 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 10:40:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e0cd389bff2833c0b13179977b11ec216330bb3
Cr-Commit-Position: refs/heads/master@{#37133}

Powered by Google App Engine
This is Rietveld 408576698