Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2080663005: Fixes blink.net's Resource trace event. (Closed)

Created:
4 years, 6 months ago by gabadie
Modified:
4 years, 6 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes blink.net's Resource trace event. https://codereview.chromium.org/1889973002/ changed the id of the blink.net's Resource async BEGIN trace event, but forgot to change the id of the associated END and STEP_INTO trace event, resulting to bug in trace offline processing could not pair all the events of the same resource together. BUG=582080, 603428 Committed: https://crrev.com/f550e093c40365f4c2d777e53f0ab1f46ddc6361 Cr-Commit-Position: refs/heads/master@{#401037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080663005/1
4 years, 6 months ago (2016-06-21 16:21:11 UTC) #2
Nate Chapin
Code change LGTM, but please mention exactly what was broken in the patch description.
4 years, 6 months ago (2016-06-21 16:23:45 UTC) #4
gabadie
On 2016/06/21 16:23:45, Nate Chapin wrote: > Code change LGTM, but please mention exactly what ...
4 years, 6 months ago (2016-06-21 16:30:11 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-21 17:45:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080663005/1
4 years, 6 months ago (2016-06-21 17:47:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 17:53:18 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 18:16:19 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f550e093c40365f4c2d777e53f0ab1f46ddc6361
Cr-Commit-Position: refs/heads/master@{#401037}

Powered by Google App Engine
This is Rietveld 408576698