Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2080663003: Disable ScaleFilterCols_SSSE3 which produces color shift (Closed)

Created:
4 years, 6 months ago by fbarchard1
Modified:
4 years, 6 months ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Disable ScaleFilterCols_SSSE3 which produces color shift upscale a YUV image. observe change in hue.. green especially. disable ScaleFilterCols_SSSE3, falling back on ScaleFilterCols_C observe hue.. green especially, is better. disable HAS_SCALEFILTERCOLS_SSSE3 R=harryjin@google.com BUG=libyuv:605 TESTED=local build unittests pass. Committed: https://chromium.googlesource.com/libyuv/libyuv/+/e376b06d6ab8a0b65f690b3b739b49d1cc75ac21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M docs/environment_variables.md View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/scale_row.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
fbarchard1
4 years, 6 months ago (2016-06-20 17:35:19 UTC) #1
harryjin
lgtm
4 years, 6 months ago (2016-06-20 17:42:48 UTC) #2
fbarchard1
Committed patchset #1 (id:1) manually as e376b06d6ab8a0b65f690b3b739b49d1cc75ac21 (presubmit successful).
4 years, 6 months ago (2016-06-20 17:43:16 UTC) #4
fbarchard1
4 years, 6 months ago (2016-06-20 18:08:35 UTC) #6
Message was sent while issue was closed.
Was
out/Release/libyuv_unittest --gtest_filter=*.ScaleFrom640x360_*
--libyuv_width=2880 --libyuv_height=1800 --libyuv_repeat=999 --libyuv_flags=-1
--libyuv_cpu_info=-1 | grep ms
[       OK ] LibYUVScaleTest.ScaleFrom640x360_None (4573 ms)
[       OK ] LibYUVScaleTest.ScaleFrom640x360_Linear (1720 ms)
[       OK ] LibYUVScaleTest.ScaleFrom640x360_Bilinear (2246 ms)
[       OK ] LibYUVScaleTest.ScaleFrom640x360_Box (2243 ms)
[----------] 4 tests from LibYUVScaleTest (10783 ms total)

Now
out/Release/libyuv_unittest --gtest_filter=*.ScaleFrom640x360_*
--libyuv_width=2880 --libyuv_height=1800 --libyuv_repeat=999 --libyuv_flags=-1
--libyuv_cpu_info=-1 | grep ms
[       OK ] LibYUVScaleTest.ScaleFrom640x360_None (4194 ms)
[       OK ] LibYUVScaleTest.ScaleFrom640x360_Linear (2154 ms)
[       OK ] LibYUVScaleTest.ScaleFrom640x360_Bilinear (2681 ms)
[       OK ] LibYUVScaleTest.ScaleFrom640x360_Box (2679 ms)
[----------] 4 tests from LibYUVScaleTest (11708 ms total)

Powered by Google App Engine
This is Rietveld 408576698